Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 68853002: Revert "Add support in gclient for pre-DEPS hooks" (Closed)

Created:
7 years, 1 month ago by borenet
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Michael Moss
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Revert "Add support in gclient for pre-DEPS hooks" This reverts commit 2d1ee9ec79f05eb1f9cf448fe2cf0b49b7f73658. We can add this functionality back if we decide we want it, but for now it's sitting around unused. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -184 lines) Patch
M gclient.py View 11 chunks +1 line, -57 lines 0 comments Download
M testing_support/fake_repos.py View 3 chunks +2 lines, -51 lines 0 comments Download
M tests/gclient_smoketest.py View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
borenet
7 years, 1 month ago (2013-11-11 14:51:57 UTC) #1
iannucci
On 2013/11/11 14:51:57, borenet wrote: lgtm :/
7 years, 1 month ago (2013-11-11 20:10:32 UTC) #2
iannucci
On 2013/11/11 20:10:32, iannucci wrote: > On 2013/11/11 14:51:57, borenet wrote: > > lgtm :/ ...
7 years, 1 month ago (2013-11-11 20:10:57 UTC) #3
borenet
On 2013/11/11 20:10:57, iannucci wrote: > On 2013/11/11 20:10:32, iannucci wrote: > > On 2013/11/11 ...
7 years, 1 month ago (2013-11-11 20:15:20 UTC) #4
borenet
On 2013/11/11 20:15:20, borenet wrote: > On 2013/11/11 20:10:57, iannucci wrote: > > On 2013/11/11 ...
7 years, 1 month ago (2013-11-12 18:52:36 UTC) #5
cmp
On 2013/11/12 18:52:36, borenet wrote: > When the original CL was committed, we carefully rolled ...
7 years, 1 month ago (2013-11-12 19:10:04 UTC) #6
borenet
On 2013/11/12 19:10:04, cmp wrote: > On 2013/11/12 18:52:36, borenet wrote: > > When the ...
7 years ago (2013-11-26 16:06:00 UTC) #7
M-A Ruel
lgtm
7 years ago (2013-11-26 16:06:43 UTC) #8
cmp
7 years ago (2013-11-26 23:50:04 UTC) #9
+mmoss who is current trooper

Powered by Google App Engine
This is Rietveld 408576698