chrome/browser/about_flags.cc - Issue 688523002: [Cocoa] Tab audio mute control, behind a switch (off by default).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 688523002: [Cocoa] Tab audio mute control, behind a switch (off by default). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Prevent TabStripController from unconditionally causing creation of MediaIndicatorButton. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 5aff454e3998d22adc9da31788f3d1660554f4d6..28b07f546a7eb4db8e7e217836f844b8fae6733b 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1965,15 +1965,13 @@ const Experiment kExperiments[] = {

SINGLE_VALUE_TYPE(chromeos::switches::kWakeOnPackets)

#endif // OS_CHROMEOS

-#if defined(USE_AURA)

{

"enable-tab-audio-muting",

IDS_FLAGS_ENABLE_TAB_AUDIO_MUTING_NAME,

IDS_FLAGS_ENABLE_TAB_AUDIO_MUTING_DESCRIPTION,

- kOsWin | kOsLinux | kOsCrOS,

+ kOsDesktop,

SINGLE_VALUE_TYPE(switches::kEnableTabAudioMuting)

-#endif // defined(USE_AURA)

{

"enable-credential-manager-api",

IDS_FLAGS_CREDENTIAL_MANAGER_API_NAME,

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tabs/media_indicator_button.h » ('j') | chrome/browser/ui/cocoa/tabs/media_indicator_button.mm » ('J')