Issue 688513004: DevTools: Migrate elements panel undo/redo shortcuts to declarative actions.

Issue 688513004: DevTools: Migrate elements panel undo/redo shortcuts to declarative actions. (Closed)

Created:
6 years, 1 month ago by vsevik

Modified:
6 years, 1 month ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Migrate elements panel undo/redo shortcuts to declarative actions. R=apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184991

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments addressed #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -32 lines)			Patch
	M	Source/devtools/front_end/elements/ElementsPanel.js	View	1	4 chunks	+60 lines, -32 lines	1 comment	Download
	M	Source/devtools/front_end/elements/module.json	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

apavlov

https://codereview.chromium.org/688513004/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/688513004/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode698 Source/devtools/front_end/elements/ElementsPanel.js:698: if (treeOutline.editing()) You should also check that no sidebar ...

6 years, 1 month ago (2014-11-07 17:24:49 UTC) #2

apavlov

lgtm https://codereview.chromium.org/688513004/diff/20001/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/688513004/diff/20001/Source/devtools/front_end/elements/ElementsPanel.js#newcode704 Source/devtools/front_end/elements/ElementsPanel.js:704: if (!treeOutline || WebInspector.isEditing()) Great. IIRC, this will ...

6 years, 1 month ago (2014-11-07 19:43:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688513004/20001

6 years, 1 month ago (2014-11-07 20:26:31 UTC) #6

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 184991

6 years, 1 month ago (2014-11-07 21:36:20 UTC) #7

apavlov

6 years ago (2014-11-28 10:25:36 UTC) #8

Message was sent while issue was closed.

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/768773002/ by apavlov@chromium.org.

The reason for reverting is: http://crbug.com/437391.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages