Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: components/bookmarks/browser/bookmark_model.h

Issue 688473005: Make sure to update the BookmarkIndex on a URL Change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.h
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
index bf0ded9836627d0067b899b9e19ffd39410455d7..f1166e87abd38ca89695c9c15a376c037ab96451 100644
--- a/components/bookmarks/browser/bookmark_model.h
+++ b/components/bookmarks/browser/bookmark_model.h
@@ -324,8 +324,8 @@ class BookmarkModel : public KeyedService {
// type specifies how the node should be removed.
void RemoveAndDeleteNode(BookmarkNode* delete_me);
- // Remove |node| from |nodes_ordered_by_url_set_|.
- void RemoveNodeFromURLSet(BookmarkNode* node);
+ // Remove |node| from |nodes_ordered_by_url_set_| and |index_|.
+ void RemoveNodeFromInternalMaps(BookmarkNode* node);
// Adds the |node| at |parent| in the specified |index| and notifies its
// observers.
@@ -333,6 +333,9 @@ class BookmarkModel : public KeyedService {
int index,
BookmarkNode* node);
+ // Adds the |node| to |nodes_ordered_by_url_set_| and |index_|.
+ void AddNodeToInternalMaps(BookmarkNode* node);
+
// Returns true if the parent and index are valid.
bool IsValidIndex(const BookmarkNode* parent, int index, bool allow_end);

Powered by Google App Engine
This is Rietveld 408576698