Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 688473005: Make sure to update the BookmarkIndex on a URL Change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/bookmark_index_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks/browser/bookmark_model.cc
diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc
index 60e143caf4f38ccb184bca21ef82b37750874da4..f974d28237d7f1d7303860f6ebc2500fc9793757 100644
--- a/components/bookmarks/browser/bookmark_model.cc
+++ b/components/bookmarks/browser/bookmark_model.cc
@@ -372,7 +372,9 @@ void BookmarkModel::SetURL(const BookmarkNode* node, const GURL& url) {
{
base::AutoLock url_lock(url_lock_);
RemoveNodeFromURLSet(mutable_node);
sky 2014/11/03 20:44:46 I think it would be less error prone if RemoveNode
+ index_->Remove(node);
mutable_node->set_url(url);
+ index_->Add(node);
nodes_ordered_by_url_set_.insert(mutable_node);
}
« no previous file with comments | « components/bookmarks/browser/bookmark_index_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698