Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 688473004: [Win] Make drawAttention on shaped windows only flash taskbar icon. (Closed)

Created:
6 years, 1 month ago by jackhou1
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Win] Make drawAttention on shaped windows only flash taskbar icon. Flashing the icon and title bar on a shaped window causes the window to flicker (see bug). Shaped windows have no title bar anyway, so just flash the taskbar icon. BUG=426283 Committed: https://crrev.com/b9924f89fade35d7900ca7cb99b5b3617f058af7 Cr-Commit-Position: refs/heads/master@{#301787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
sky, could you take look?
6 years, 1 month ago (2014-10-29 03:18:30 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-10-29 03:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688473004/1
6 years, 1 month ago (2014-10-29 04:09:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 04:56:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 04:56:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9924f89fade35d7900ca7cb99b5b3617f058af7
Cr-Commit-Position: refs/heads/master@{#301787}

Powered by Google App Engine
This is Rietveld 408576698