Added swarming step to the Blink trybots

Added swarming step to the Blink trybots

BUG=426897
R=*kbr@chromium.org,phajdan.jr@chromium.org,maruel@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292732

[Sergiy Byelozyorov, 2014-10-28 21:48:39]

sergiyb@chromium.org changed reviewers:
+ kbr@chromium.org

[Sergiy Byelozyorov, 2014-10-28 21:53:24]

PTAL

[Sergiy Byelozyorov, 2014-10-28 22:00:50]

sergiyb@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Sergiy Byelozyorov, 2014-10-28 22:01:10]

Added Pawel. PTAL

[Ken Russell (switch to Gerrit), 2014-10-29 02:15:43]

This looks good to me but I'm not an owner in this directory. I also didn't have
time today to compare this to the earlier CLs which added this support to the
other recipes.

[Paweł Hajdan Jr., 2014-10-29 10:14:47]

https://codereview.chromium.org/688473003/diff/40001/scripts/slave/recipes/bl...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/688473003/diff/40001/scripts/slave/recipes/bl...
scripts/slave/recipes/blink_trybot.py:280:
api.swarming.set_default_dimension('pool', 'Chrome')
This seems duplicated from chromium_trybot.py recipe.

Please extract it e.g. to chromium_tests recipe module.

[Sergiy Byelozyorov, 2014-10-29 13:01:25]

https://codereview.chromium.org/688473003/diff/40001/scripts/slave/recipes/bl...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/688473003/diff/40001/scripts/slave/recipes/bl...
scripts/slave/recipes/blink_trybot.py:280:
api.swarming.set_default_dimension('pool', 'Chrome')
On 2014/10/29 10:14:46, Paweł Hajdan Jr. wrote:
> This seems duplicated from chromium_trybot.py recipe.
> 
> Please extract it e.g. to chromium_tests recipe module.

Done.

[M-A Ruel, 2014-10-29 13:04:48]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2014-10-29 13:04:50]

Sorry to expand the CL but could you do chromium.py too so more code is merged
together?

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:470: def
configure_swarming(self, project_name):
Add precommit as a parameter.

It'd be a bool value.

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:479:
self.m.swarming.add_default_tag('purpose:pre-commit')
self.m.swarming.add_default_tag('purpose:pre-commit' if precommit else
'purpose:post-commit')

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:482: requester =
self.m.properties.get('requester')
if precommit:
  <lines 482-492>
else:
  self.m.swarming.default_priority = 25

[Sergiy Byelozyorov, 2014-10-29 13:20:42]

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:470: def
configure_swarming(self, project_name):
On 2014/10/29 13:04:50, M-A Ruel wrote:
> Add precommit as a parameter.
> 
> It'd be a bool value.

Done.

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:479:
self.m.swarming.add_default_tag('purpose:pre-commit')
On 2014/10/29 13:04:50, M-A Ruel wrote:
> self.m.swarming.add_default_tag('purpose:pre-commit' if precommit else
> 'purpose:post-commit')

Done.

https://codereview.chromium.org/688473003/diff/60001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:482: requester =
self.m.properties.get('requester')
On 2014/10/29 13:04:50, M-A Ruel wrote:
> if precommit:
>   <lines 482-492>
> else:
>   self.m.swarming.default_priority = 25

Done. Also added

self.m.swarming.add_default_tag('purpose:CI')

to have identical behavior with chromium.py

[Paweł Hajdan Jr., 2014-10-29 14:11:11]

LGTM

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:475: build_properties: Build
properties object (api.properties in the recipe).
This comment seems no longer accurate.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
scripts/slave/recipes/blink_trybot.py:279: api.chromium.compile()
Early return here and de-indent everything below.

[M-A Ruel, 2014-10-29 14:14:27]

This looks good.

A few fix to make the expectations more in line with that they should be.

My main concern at the moment is uploading large quantity of isolated content
that is not being used. The actual amount will depend on what is being built in
the first place.

On the chromium side there's testing/buildbot/
tryserver.chromium.*.json which sets can_use_on_swarming_builders:true only on
the ones relevant, which saves a lot. Sadly AFAIK there's no equivalent for
blink recipes.

Vadim would know but he's ooo.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:470: def
configure_swarming(self, project_name, precommit=True):
I'd prefer no default value.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
File scripts/slave/recipes/blink_trybot.expected/non_cq_tryjob.json (left):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
scripts/slave/recipes/blink_trybot.expected/non_cq_tryjob.json:6:
"[BUILD]\\scripts\\slave\\bot_update.py",
There's a bug in the recipe code that uses OS's join and this file was last
uploaded by a Windows dev.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
(right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json:305:
"purpose:CQ",
Oh.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:898:
api.chromium_tests.configure_swarming('chromium')
precommit=True

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1173: api.properties.generic(
Can you convert it to:
props(buildername='linux_arm', requestor='commit-bot@chromium.org',
blamelist='joe@chromium.org', blamelist_real=['joe@chromium.org'])

it's the only one not using it, it's likely an oversight.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1252:
props(buildername='linux_chromium_rel') +
Please use:
props(
    requestor='commit-bot@chromium.org',
    blamelist='joe@chromium.org',
    blamelist_real=['joe@chromium.org'])

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1325:
props(buildername='linux_chromium_rel') +
Please use:
props(
    requestor='commit-bot@chromium.org',
    blamelist='joe@chromium.org',
    blamelist_real=['joe@chromium.org'])

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1357:
props(buildername='linux_chromium_rel') +
Please use:
props(
    requestor='commit-bot@chromium.org',
    blamelist='joe@chromium.org',
    blamelist_real=['joe@chromium.org'])

[Sergiy Byelozyorov, 2014-10-29 14:23:07]

The CQ bit was checked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-10-29 14:23:33]

The CQ bit was unchecked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-10-29 14:43:45]

I agree that this CL adds a lot of swarming stuff but not the swarming tests
themselves. However, we are certain that we are going to do swarming tests and
that we need to run preparatory steps for them that are added in this CL.

Creating a test spec for GPU bots is a large task and I'd prefer to write a
separate CL for it. This CL already contains too many irrelevant changes.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:470: def
configure_swarming(self, project_name, precommit=True):
On 2014/10/29 14:14:27, M-A Ruel wrote:
> I'd prefer no default value.

Done.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_tests/api.py:475: build_properties: Build
properties object (api.properties in the recipe).
On 2014/10/29 14:11:11, Paweł Hajdan Jr. wrote:
> This comment seems no longer accurate.

Done.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
File scripts/slave/recipes/blink_trybot.expected/non_cq_tryjob.json (left):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
scripts/slave/recipes/blink_trybot.expected/non_cq_tryjob.json:6:
"[BUILD]\\scripts\\slave\\bot_update.py",
On 2014/10/29 14:14:27, M-A Ruel wrote:
> There's a bug in the recipe code that uses OS's join and this file was last
> uploaded by a Windows dev.

This file was created in this patchset since I've created this test to provide
coverage. It was just similar to an existing one and Diff thought that I've
coped it.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/bl...
scripts/slave/recipes/blink_trybot.py:279: api.chromium.compile()
On 2014/10/29 14:11:11, Paweł Hajdan Jr. wrote:
> Early return here and de-indent everything below.

Done.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
(right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json:305:
"purpose:CQ",
On 2014/10/29 14:14:27, M-A Ruel wrote:
> Oh.

Indeed. :-)

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:898:
api.chromium_tests.configure_swarming('chromium')
On 2014/10/29 14:14:27, M-A Ruel wrote:
> precommit=True

Done.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1173: api.properties.generic(
On 2014/10/29 14:14:27, M-A Ruel wrote:
> Can you convert it to:
> props(buildername='linux_arm', mailto:requestor=,
> mailto:blamelist=, mailto:blamelist_real=[)
> 
> it's the only one not using it, it's likely an oversight.

Done. Also renamed "requestor" to "requester" here and below.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1252:
props(buildername='linux_chromium_rel') +
On 2014/10/29 14:14:27, M-A Ruel wrote:
> Please use:
> props(
>     mailto:requestor=,
>     mailto:blamelist=,
>     mailto:blamelist_real=[)

Done.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1325:
props(buildername='linux_chromium_rel') +
On 2014/10/29 14:14:27, M-A Ruel wrote:
> Please use:
> props(
>     mailto:requestor=,
>     mailto:blamelist=,
>     mailto:blamelist_real=[)

Done.

https://codereview.chromium.org/688473003/diff/80001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium_trybot.py:1357:
props(buildername='linux_chromium_rel') +
On 2014/10/29 14:14:27, M-A Ruel wrote:
> Please use:
> props(
>     mailto:requestor=,
>     mailto:blamelist=,
>     mailto:blamelist_real=[)

Done.

[Sergiy Byelozyorov, 2014-10-29 14:59:40]

sergiyb@chromium.org changed required reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2014-10-29 16:33:05]

On 2014/10/29 14:14:27, M-A Ruel wrote:
> My main concern at the moment is uploading large quantity of isolated content
> that is not being used. The actual amount will depend on what is being built
in
> the first place.
> 
> On the chromium side there's testing/buildbot/
> tryserver.chromium.*.json which sets can_use_on_swarming_builders:true only on
> the ones relevant, which saves a lot. Sadly AFAIK there's no equivalent for
> blink recipes.

That raises a question. The blink trybots currently build the target
"blink_tests". See e.g.
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/290...
. I would hope that that wouldn't cause any isolate targets to be built or
uploaded yet, even with this CL. Do you think that is the case?

[Sergiy Byelozyorov, 2014-10-29 17:14:59]

On 2014/10/29 16:33:05, Ken Russell wrote:
> On 2014/10/29 14:14:27, M-A Ruel wrote:
> > My main concern at the moment is uploading large quantity of isolated
content
> > that is not being used. The actual amount will depend on what is being built
> in
> > the first place.
> > 
> > On the chromium side there's testing/buildbot/
> > tryserver.chromium.*.json which sets can_use_on_swarming_builders:true only
on
> > the ones relevant, which saves a lot. Sadly AFAIK there's no equivalent for
> > blink recipes.
> 
> That raises a question. The blink trybots currently build the target
> "blink_tests". See e.g.
>
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/290...
> . I would hope that that wouldn't cause any isolate targets to be built or
> uploaded yet, even with this CL. Do you think that is the case?

Isolate files will only be built and uploaded when respective steps are added to
the webkit_tests.
This can only be done after creating webkit_tests.isolate file and
webkit_tests_run build rule first.
This CL only configures swarming - doesn't actually use it yet. It also fixes a
few errors in the expectations.

[Ken Russell (switch to Gerrit), 2014-10-29 17:36:45]

On 2014/10/29 17:14:59, Sergiy Byelozyorov wrote:
> On 2014/10/29 16:33:05, Ken Russell wrote:
> > On 2014/10/29 14:14:27, M-A Ruel wrote:
> > > My main concern at the moment is uploading large quantity of isolated
> content
> > > that is not being used. The actual amount will depend on what is being
built
> > in
> > > the first place.
> > > 
> > > On the chromium side there's testing/buildbot/
> > > tryserver.chromium.*.json which sets can_use_on_swarming_builders:true
only
> on
> > > the ones relevant, which saves a lot. Sadly AFAIK there's no equivalent
for
> > > blink recipes.
> > 
> > That raises a question. The blink trybots currently build the target
> > "blink_tests". See e.g.
> >
>
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/290...
> > . I would hope that that wouldn't cause any isolate targets to be built or
> > uploaded yet, even with this CL. Do you think that is the case?
> 
> Isolate files will only be built and uploaded when respective steps are added
to
> the webkit_tests.
> This can only be done after creating webkit_tests.isolate file and
> webkit_tests_run build rule first.
> This CL only configures swarming - doesn't actually use it yet. It also fixes
a
> few errors in the expectations.

OK. Thanks for the clarification.

[M-A Ruel, 2014-10-29 18:11:01]

lgtm

This CL will conflict with https://codereview.chromium.org/654543008/.

In theory it would likely been better to do the chromium.py&chromium_trybot.py
change first then blink_try.py but I already asked enough and it's fine to do a
partial revert.

Please ensure the trooper is aware of this change and monitor the first build on
each relevant masters (Chromium TS, Blink TS, CI) to ensure they work fine.

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_trybot.py:900: # TODO(phajdan): uncomment once we
have XP or 10.6 trybots.
Remove 900-903 while at it. It's stale.

[Ken Russell (switch to Gerrit), 2014-10-29 19:16:16]

LGTM with a couple of comments.

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:484: requester =
self.m.properties.get('requester')
Wow. One of the tests of the "requester" build property has been broken all
along due to a typo ("requestor").

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/b...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/b...
scripts/slave/recipes/blink_trybot.py:392:
blamelist_real=['someone@chromium.org']) +
Is this really necessary for code coverage? It causes a lot of spurious test
expectation changes.

[Sergiy Byelozyorov, 2014-10-29 20:04:25]

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:484: requester =
self.m.properties.get('requester')
On 2014/10/29 19:16:16, Ken Russell wrote:
> Wow. One of the tests of the "requester" build property has been broken all
> along due to a typo ("requestor").

Yeah. I've actually grepped whole repo for "requestor" to make sure there are no
other places with this typo.

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/b...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/b...
scripts/slave/recipes/blink_trybot.py:392:
blamelist_real=['someone@chromium.org']) +
On 2014/10/29 19:16:16, Ken Russell wrote:
> Is this really necessary for code coverage? It causes a lot of spurious test
> expectation changes.

It's either that or adding another test with a single reviewer in blamelist
(covers line 490 in chromium_tests/api.py). Adding more tests is always bad,
because it forces everyone review yet another test after changes. Having two
reviewers doesn't really cover any functionality.

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/688473003/diff/120001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_trybot.py:900: # TODO(phajdan): uncomment once we
have XP or 10.6 trybots.
On 2014/10/29 18:11:01, M-A Ruel wrote:
> Remove 900-903 while at it. It's stale.

Done.

[Sergiy Byelozyorov, 2014-10-29 20:11:32]

The CQ bit was checked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-10-29 20:11:44]

The CQ bit was unchecked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2014-10-29 20:11:44]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2014-10-29 20:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688473003/140001

[commit-bot: I haz the power, 2014-10-29 20:12:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 20:12:56]

Failed to apply patch for
build/scripts/slave/recipes/chromium_trybot.expected/arm.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/scripts/slave/recipes/chromium_trybot.expected/arm.json
  Hunk #2 FAILED at 135.
  1 out of 2 hunks FAILED -- saving rejects to file
build/scripts/slave/recipes/chromium_trybot.expected/arm.json.rej

Patch:       build/scripts/slave/recipes/chromium_trybot.expected/arm.json
Index: scripts/slave/recipes/chromium_trybot.expected/arm.json
diff --git build/scripts/slave/recipes/chromium_trybot.expected/arm.json
build/scripts/slave/recipes/chromium_trybot.expected/arm.json
index
16bc459d61cb807e1bdb38609d371c6448c739f3..8ccfab8c8ef620f5e67873502960baca19007fb0
100644
--- a/build/scripts/slave/recipes/chromium_trybot.expected/arm.json
+++ b/build/scripts/slave/recipes/chromium_trybot.expected/arm.json
@@ -12,8 +12,16 @@
       "TestSlavename",
       "--spec",
       "cache_dir = None\nsolutions = [{'custom_vars': {'googlecode_url':
'svn://svn-mirror.golo.chromium.org/%s', 'nacl_trunk':
'svn://svn-mirror.golo.chromium.org/native_client/trunk', 'sourceforge_url':
'svn://svn-mirror.golo.chromium.org/%(repo)s', 'webkit_trunk':
'svn://svn-mirror.golo.chromium.org/blink/trunk'}, 'deps_file': 'DEPS',
'managed': True, 'name': 'src', 'url':
'svn://svn-mirror.golo.chromium.org/chrome/trunk/src'}]",
+      "--root",
+      "src",
       "--revision_mapping_file",
       "{\"src\": \"got_revision\", \"src/native_client\":
\"got_nacl_revision\", \"src/third_party/WebKit\": \"got_webkit_revision\",
\"src/third_party/webrtc\": \"got_webrtc_revision\",
\"src/tools/swarming_client\": \"got_swarming_client_revision\", \"src/v8\":
\"got_v8_revision\"}",
+      "--issue",
+      "12853011",
+      "--patchset",
+      "1",
+      "--rietveld_server",
+      "https://codereview.chromium.org",
       "--output_json",
       "/path/to/tmp/json",
       "--revision",
@@ -127,66 +135,137 @@
     "cmd": [
       "python",
       "-u",
-      "[DEPOT_TOOLS]/gclient.py",
-      "runhooks"
+      "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
+      "[SLAVE_BUILD]/src/testing/buildbot/trybot_analyze_config.json",
+      "/path/to/tmp/json"
+    ],
+    "name": "read filter exclusion spec",
+    "~followup_annotations": [
+      "@@@STEP_TEXT@path: 'testing/buildbot/trybot_analyze_config.json'@@@",
+      "@@@STEP_LOG_LINE@json.output@{@@@",
+      "@@@STEP_LOG_LINE@json.output@  \"base\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@    \"exclusions\": []@@@",
+      "@@@STEP_LOG_LINE@json.output@  }, @@@",
+      "@@@STEP_LOG_LINE@json.output@  \"chromium\": {@@@",
+      "@@@STEP_LOG_LINE@json.output@    \"exclusions\": []@@@",
+      "@@@STEP_LOG_LINE@json.output@  }@@@",
+      "@@@STEP_LOG_LINE@json.output@}@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
+  },
+  {
+    "cmd": [
+      "git",
+      "diff",
+      "--cached",
+      "--name-only"
+    ],
+    "cwd": "[SLAVE_BUILD]/src",
+    "name": "git diff to analyze patch",
+    "stdout": "/path/to/tmp/"
+  },
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "[SLAVE_BUILD]/src/build/gyp_chromium",
+      "--analyzer",
+      "{\"files\": [\"foo.cc\"], \"targets\": [\"browser_tests\",
\"base_tests\", \"chrome\"]}",
+      "/path/to/tmp/json"
     ],
     "env": {
       "GYP_CROSSCOMPILE": "1",
-      "GYP_DEFINES": "arm_float_abi=hard component=static_library
dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm
test_isolation_mode=archive
test_isolation_outdir=https://isolateserver.appspot.com use_goma=1"
+      "GYP_DEFINES": "arm_float_abi=hard component=static_library
dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm
test_isolation_mode=archive use_goma=1"
     },
-    "name": "gclient runhooks (with patch)"
+    "name": "analyze",
+    "~followup_annotations": [
+      "@@@STEP_TEXT@No compile necessary@@@",
+      "@@@STEP_LOG_LINE@json.output@{@@@",
+      "@@@STEP_LOG_LINE@json.output@  \"build_targets\": [], @@@",
+      "@@@STEP_LOG_LINE@json.output@  \"status\": \"No dependency\", @@@",
+      "@@@STEP_LOG_LINE@json.output@  \"targets\": []@@@",
+      "@@@STEP_LOG_LINE@json.output@}@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
   },
   {
     "cmd": [
       "python",
       "-u",
-     
"[BUILD]/scripts/slave/recipe_modules/isolate/resources/find_isolated_tests.py",
-      "--build-dir",
-      "[SLAVE_BUILD]/src/out/Release",
-      "--clean-isolated-files"
+      "[SLAVE_BUILD]/src/testing/scripts/checkdeps.py",
+      "--build-config-fs",
+      "Release",
+      "--paths",
+      "{\"build\": \"[BUILD]\"}",
+      "--properties",
+      "{\"buildername\": \"linux_arm\", \"buildnumber\": 571, \"slavename\":
\"TestSlavename\"}",
+      "run",
+      "--output",
+      "/path/to/tmp/json"
     ],
-    "name": "clean isolated files"
+    "name": "checkdeps (with patch)",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@json.output@{@@@",
+      "@@@STEP_LOG_LINE@json.output@  \"failures\": [], @@@",
+      "@@@STEP_LOG_LINE@json.output@  \"valid\": true@@@",
+      "@@@STEP_LOG_LINE@json.output@}@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
   },
   {
     "cmd": [
       "python",
       "-u",
-      "[BUILD]/scripts/slave/compile.py",
-      "--target",
-      "Release",
-      "--src-dir",
+      "[SLAVE_BUILD]/src/tools/checkperms/checkperms.py",
+      "--root",
       "[SLAVE_BUILD]/src",
-      "--build-tool",
-      "ninja",
-      "--compiler",
-      "goma",
-      "--goma-dir",
-      "[BUILD]/goma",
-      "--",
-      "base_tests",
-      "browser_tests",
-      "browser_tests_run"
+      "--json",
+      "/path/to/tmp/json"
+    ],
+    "name": "checkperms (with patch)",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@json.output@[]@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
+  },
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "[SLAVE_BUILD]/src/tools/checklicenses/checklicenses.py",
+      "--root",
+      "[SLAVE_BUILD]/src",
+      "--json",
+      "/path/to/tmp/json"
     ],
-    "name": "compile (with patch)"
+    "name": "checklicenses (with patch)",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@json.output@[]@@@",
+      "@@@STEP_LOG_END@json.output@@@"
+    ]
   },
   {
     "cmd": [
       "python",
       "-u",
-     
"[BUILD]/scripts/slave/recipe_modules/isolate/resources/find_isolated_tests.py",
-      "--build-dir",
-      "[SLAVE_BUILD]/src/out/Release",
-      "--output-json",
+      "[SLAVE_BUILD]/src/testing/scripts/telemetry_unittests.py",
+      "--build-config-fs",
+      "Release",
+      "--paths",
+      "{\"build\": \"[BUILD]\"}",
+      "--properties",
+      "{\"buildername\": \"linux_arm\", \"buildnumber\": 571, \"slavename\":
\"TestSlavename\"}",
+      "run",
+      "--output",
       "/path/to/tmp/json"
     ],
-    "name": "find isolated tests",
+    "name": "telemetry_unittests (with patch)",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@json.output@{@@@",
-      "@@@STEP_LOG_LINE@json.output@  \"dummy_target_1\": \"[dummy hash for
dummy_target_1]\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"dummy_target_2\": \"[dummy hash for
dummy_target_2]\"@@@",
+      "@@@STEP_LOG_LINE@json.output@  \"failures\": [], @@@",
+      "@@@STEP_LOG_LINE@json.output@  \"valid\": true@@@",
       "@@@STEP_LOG_LINE@json.output@}@@@",
-      "@@@STEP_LOG_END@json.output@@@",
-      "@@@SET_BUILD_PROPERTY@swarm_hashes@{\"dummy_target_1\": \"[dummy hash
for dummy_target_1]\", \"dummy_target_2\": \"[dummy hash for
dummy_target_2]\"}@@@"
+      "@@@STEP_LOG_END@json.output@@@"
     ]
   }
 ]
\ No newline at end of file

[Sergiy Byelozyorov, 2014-10-29 20:24:20]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2014-10-29 20:24:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688473003/160001

[commit-bot: I haz the power, 2014-10-29 20:26:48]

Committed patchset #9 (id:160001) as 292732