Issue 688443006: roll dom distiller js and proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688443006: roll dom distiller js and proto (Closed)

Created:
6 years, 1 month ago by kuan

Modified:
6 years, 1 month ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

roll dom distiller js and proto Picked up changes: 62f5e92 add option for original domain 2a112e2 Add directionality test to suite and correct test case BUG=374404, 425952 Committed: https://crrev.com/1df3fe26153400331949b39dea2de8102b6f8df9 Cr-Commit-Position: refs/heads/master@{#301928}

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+551 lines, -536 lines)			Patch
M	third_party/dom_distiller_js/README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/dom_distiller_js/package/js/domdistiller.js	View	1 chunk	+536 lines, -535 lines	0 comments	Download
M	third_party/dom_distiller_js/package/proto/dom_distiller.proto	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688443006/1

6 years, 1 month ago (2014-10-29 20:16:46 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 21:12:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1df3fe26153400331949b39dea2de8102b6f8df9
Cr-Commit-Position: refs/heads/master@{#301928}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages