sky/engine/core/rendering/RenderObject.cpp - Issue 688443003: Remove a bit more position:fixed plumbing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 688443003: Remove a bit more position:fixed plumbing. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderObject.cpp

diff --git a/sky/engine/core/rendering/RenderObject.cpp b/sky/engine/core/rendering/RenderObject.cpp

index 2d357c313ca2e2adccbe6390fef9fa9b63c2c133..639fa405d47576fb4154aa1b2dfc84ae47ceb21f 100644

--- a/sky/engine/core/rendering/RenderObject.cpp

+++ b/sky/engine/core/rendering/RenderObject.cpp

@@ -635,7 +635,7 @@ RenderBlock* RenderObject::containingBlock() const

if (o->style()->position() != StaticPosition && (!o->isInline() || o->isReplaced()))

break;

- if (o->canContainFixedPositionObjects())

+ if (o->canContainAbsolutePositionObjects())

break;

if (o->style()->hasInFlowPosition() && o->isInline() && !o->isReplaced()) {

@@ -2290,7 +2290,7 @@ RenderObject* RenderObject::container(const RenderLayerModelObject* paintInvalid

if (o->style()->position() != StaticPosition)

break;

- if (o->canContainFixedPositionObjects())

+ if (o->canContainAbsolutePositionObjects())

break;

if (paintInvalidationContainerSkipped && o == paintInvalidationContainer)

« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | no next file » | no next file with comments »