sky/engine/core/rendering/RenderLayer.h - Issue 688443003: Remove a bit more position:fixed plumbing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLayer.h

Issue 688443003: Remove a bit more position:fixed plumbing. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderLayer.h

diff --git a/sky/engine/core/rendering/RenderLayer.h b/sky/engine/core/rendering/RenderLayer.h

index fb2c945b749994904b3e6a4604f7ba869a101f6c..a8394e6a527293fb356620bf7a7b66664887092f 100644

--- a/sky/engine/core/rendering/RenderLayer.h

+++ b/sky/engine/core/rendering/RenderLayer.h

@@ -367,8 +367,6 @@ public:

inline bool isPositionedContainer() const

{

// FIXME: This is not in sync with containingBlock.

- // RenderObject::canContainFixedPositionedObject() should probably be used

- // instead.

RenderLayerModelObject* layerRenderer = renderer();

return isRootLayer() || layerRenderer->isPositioned() || hasTransform();

}

« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »