Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 688433002: rework GUI, scripts, and fiddle main for multiple simultaneous configs (Closed)

Created:
6 years, 1 month ago by humper
Modified:
6 years, 1 month ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rework GUI, scripts, and fiddle main for multiple simultaneous configs You can now select Raster, Ganesh, or both (PDF coming soon), and see all output simultaneously. BUG=skia: R=jcgregorio@google.com TBR=jcgregorio Committed: https://skia.googlesource.com/skia/+/af58b5fcba23f5cc395ad64642b46504bd181eac

Patch Set 1 #

Total comments: 7

Patch Set 2 : Add TODO about polymer port and global namespacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -58 lines) Patch
M experimental/webtry/main.cpp View 4 chunks +67 lines, -26 lines 0 comments Download
M experimental/webtry/res/js/webtry.js View 1 7 chunks +61 lines, -8 lines 0 comments Download
M experimental/webtry/res/webtry/css/webtry.css View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/res/webtry/sass/webtry.scss View 1 chunk +4 lines, -0 lines 0 comments Download
M experimental/webtry/scripts/fiddle_run View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/content.html View 1 chunk +22 lines, -3 lines 0 comments Download
M experimental/webtry/templates/footercommon.html View 1 chunk +0 lines, -9 lines 0 comments Download
M experimental/webtry/templates/headercommon.html View 1 chunk +10 lines, -0 lines 0 comments Download
M experimental/webtry/templates/sidebar.html View 2 chunks +24 lines, -1 line 0 comments Download
M experimental/webtry/webtry.go View 6 chunks +36 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
ptal; happy to give demo if needed.
6 years, 1 month ago (2014-10-28 19:19:29 UTC) #1
jcgregorio
https://codereview.chromium.org/688433002/diff/1/experimental/webtry/res/js/webtry.js File experimental/webtry/res/js/webtry.js (right): https://codereview.chromium.org/688433002/diff/1/experimental/webtry/res/js/webtry.js#newcode409 experimental/webtry/res/js/webtry.js:409: function collectionHas(a, b) { //helper function (see below) Move ...
6 years, 1 month ago (2014-10-29 13:34:59 UTC) #2
jcgregorio
6 years, 1 month ago (2014-10-29 13:35:04 UTC) #3
humper
https://codereview.chromium.org/688433002/diff/1/experimental/webtry/res/js/webtry.js File experimental/webtry/res/js/webtry.js (right): https://codereview.chromium.org/688433002/diff/1/experimental/webtry/res/js/webtry.js#newcode409 experimental/webtry/res/js/webtry.js:409: function collectionHas(a, b) { //helper function (see below) On ...
6 years, 1 month ago (2014-10-29 14:20:33 UTC) #4
jcgregorio
lgtm
6 years, 1 month ago (2014-10-29 14:22:36 UTC) #5
humper
6 years, 1 month ago (2014-10-29 14:31:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
af58b5fcba23f5cc395ad64642b46504bd181eac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698