Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 68843006: Changes to SkTDStackNester. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Changes to SkTDStackNester. SkTDStackNester is a class used by PdfViewer to assist in saving and restoring the PDF state. Clean up and test this class. Add some documentation. Add FIXME's where I have questions to resolve. Fix a bug where fNestingLevel was not initialized. Remove a commented out line of code copied over from SkTDStack. Rename SkTDStackNester::nests() to nestingLevel() and make it const. Remove unnecessary predeclaration and friend declaration. Remove index() (both const and non-const versions). They were unused, return something that may not be expected (index from the top, rather than from the bottom), and don't work to get any elements in earlier Recs once the first one is full. Report a warning if the nesting level goes above the maximum level, or if we attempt to bring it below zero. Prevent fNestingLevel from dropping below zero. Add kUnusedObject_SkPdfIssue, and use it where appropriate. Depends on https://codereview.chromium.org/64093009/ R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=12328

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Add a test #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -32 lines) Patch
M experimental/PdfViewer/SkPdfReporter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M experimental/PdfViewer/SkPdfReporter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/src/SkPdfRenderer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/src/SkTDStackNester.h View 1 2 3 4 5 chunks +95 lines, -29 lines 0 comments Download
M gyp/experimental.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gyp View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
A tests/TDStackNesterTest.cpp View 1 2 3 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Right now I am trusting Edison's wisdom in his differences from SkTDStack, but it might ...
7 years, 1 month ago (2013-11-20 20:04:07 UTC) #1
mtklein
On 2013/11/20 20:04:07, scroggo wrote: > Right now I am trusting Edison's wisdom in his ...
7 years, 1 month ago (2013-11-20 20:45:13 UTC) #2
scroggo
7 years, 1 month ago (2013-11-20 21:41:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r12328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698