Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: media/cast/cast_sender.h

Issue 688423003: [Cast] VideoFrameFactory interface to vend frames with encoder affinity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reworked implementation based on review feedback. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/cast.gyp ('k') | media/cast/cast_sender_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/cast_sender.h
diff --git a/media/cast/cast_sender.h b/media/cast/cast_sender.h
index 7615c28602c8f58052f4f7bf024c4eba79bc6bcc..8ac9f014ea0acf323626463cc99bc4e3cbd2b29a 100644
--- a/media/cast/cast_sender.h
+++ b/media/cast/cast_sender.h
@@ -36,6 +36,11 @@ class VideoFrameInput : public base::RefCountedThreadSafe<VideoFrameInput> {
const scoped_refptr<media::VideoFrame>& video_frame,
const base::TimeTicks& capture_time) = 0;
+ // Creates a |VideoFrame| suitable for input via |InsertRawVideoFrame|. Frames
+ // obtained in this manner may provide benefits such memory reuse and affinity
+ // with the encoder. The format is guaranteed to be I420 or NV12.
+ virtual scoped_refptr<VideoFrame> CreateFrame(base::TimeDelta timestamp) = 0;
Alpha Left Google 2014/11/19 19:22:18 This looks good. What about adding the method bool
+
protected:
virtual ~VideoFrameInput() {}
« no previous file with comments | « media/cast/cast.gyp ('k') | media/cast/cast_sender_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698