Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 688413005: Convert the directory listing to run on top of the platform (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
rafaelw
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Convert the directory listing to run on top of the platform Previously we were using string concatenation to build up the directory listing. Now we fetch some JSON from the server and use data binding to inflate a directory listing. This exmaple doesn't work yet because we're missing support for template@repeat, but hopefully we'll get that soon. Also, added support for setRequestHeader to XMLHttpRequest. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/00720115e085a41ab160a222543d3b90626e5d58

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -15 lines) Patch
A sky/examples/file-browser.sky View 1 chunk +41 lines, -0 lines 1 comment Download
M sky/framework/xmlhttprequest.sky View 2 chunks +12 lines, -0 lines 0 comments Download
M sky/tools/sky_server View 2 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-03 19:26:55 UTC) #1
rafaelw
lgtm https://codereview.chromium.org/688413005/diff/1/sky/examples/file-browser.sky File sky/examples/file-browser.sky (right): https://codereview.chromium.org/688413005/diff/1/sky/examples/file-browser.sky#newcode16 sky/examples/file-browser.sky:16: <template repeat="{{ directory in directories }}"> if you ...
6 years, 1 month ago (2014-11-03 20:06:04 UTC) #2
abarth-chromium
On 2014/11/03 at 20:06:04, rafaelw wrote: > lgtm > > https://codereview.chromium.org/688413005/diff/1/sky/examples/file-browser.sky > File sky/examples/file-browser.sky (right): ...
6 years, 1 month ago (2014-11-03 20:53:12 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-03 20:53:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00720115e085a41ab160a222543d3b90626e5d58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698