Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 688363003: add textblobs to lua (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : add virtual destructor to fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -19 lines) Patch
M include/utils/SkTextBox.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M resources/slides.lua View 1 4 chunks +22 lines, -4 lines 0 comments Download
M src/utils/SkLua.cpp View 7 chunks +51 lines, -1 line 0 comments Download
M src/utils/SkTextBox.cpp View 1 2 4 chunks +58 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688363003/20001
6 years, 1 month ago (2014-11-03 22:24:22 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/434) Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/406) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 1 month ago (2014-11-03 22:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688363003/40001
6 years, 1 month ago (2014-11-04 03:39:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/416) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/427)
6 years, 1 month ago (2014-11-04 03:40:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688363003/60001
6 years, 1 month ago (2014-11-04 03:44:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 03:55:44 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 1b6ab4417e0edef3b91d150e6650205f49f04d17

Powered by Google App Engine
This is Rietveld 408576698