Add some missing ENABLE_PLUGINS ifdefs.

Add some missing ENABLE_PLUGINS ifdefs.

This is a spinoff from: https://codereview.chromium.org/680193002/

BUG=NONE

Committed: https://crrev.com/e6633ca726043764a934add484216acc0b24445f
Cr-Commit-Position: refs/heads/master@{#302199}

[tommycli, 2014-10-30 21:14:05]

tommycli@chromium.org changed reviewers:
+ thestig@chromium.org

[tommycli, 2014-10-30 21:14:06]

thestig: I spun off the ifdef(ENABLE_PLUGINS) changes into a separate CL. Are
these in line with your other ENABLE_PLUGINS changes?

[Lei Zhang, 2014-10-30 21:48:54]

https://codereview.chromium.org/688343003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager_unittest.cc (right):

https://codereview.chromium.org/688343003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager_unittest.cc:213: #if
defined(ENABLE_PLUGINS)
I think you can get away without the ifdefs in PluginFaviconMessageObserver. It
doesn't reference any plugin classes directly and it's in a test file, so it's
not bytes shipped to users.

https://codereview.chromium.org/688343003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.cc (right):

https://codereview.chromium.org/688343003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.cc:222: #if
defined(ENABLE_PLUGINS)
ENABLE_PLUGINS is for PPAPI only. All the NPAPI code is going away soon anyway.

https://codereview.chromium.org/688343003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/688343003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:498: #if
defined(ENABLE_PLUGINS)
There's already another ENABLE_PLUGINS section below. Move it there?

[tommycli, 2014-10-30 22:37:21]

thestig: cool thanks

https://codereview.chromium.org/688343003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager_unittest.cc (right):

https://codereview.chromium.org/688343003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager_unittest.cc:213: #if
defined(ENABLE_PLUGINS)
On 2014/10/30 21:48:54, Lei Zhang wrote:
> I think you can get away without the ifdefs in PluginFaviconMessageObserver.
It
> doesn't reference any plugin classes directly and it's in a test file, so it's
> not bytes shipped to users.

Done.

https://codereview.chromium.org/688343003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.cc (right):

https://codereview.chromium.org/688343003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.cc:222: #if
defined(ENABLE_PLUGINS)
On 2014/10/30 21:48:54, Lei Zhang wrote:
> ENABLE_PLUGINS is for PPAPI only. All the NPAPI code is going away soon
anyway.

Done.

https://codereview.chromium.org/688343003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/688343003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:498: #if
defined(ENABLE_PLUGINS)
On 2014/10/30 21:48:54, Lei Zhang wrote:
> There's already another ENABLE_PLUGINS section below. Move it there?

Done.

[Lei Zhang, 2014-10-30 22:39:44]

lgtm

https://codereview.chromium.org/688343003/diff/40001/content/common/frame_mes...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/688343003/diff/40001/content/common/frame_mes...
content/common/frame_messages.h:635: #endif  // defined(ENABLE_PLUGINS)
nit: no blank line above.

[tommycli, 2014-10-30 23:22:14]

cool thanks!

https://codereview.chromium.org/688343003/diff/40001/content/common/frame_mes...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/688343003/diff/40001/content/common/frame_mes...
content/common/frame_messages.h:635: #endif  // defined(ENABLE_PLUGINS)
On 2014/10/30 22:39:44, Lei Zhang wrote:
> nit: no blank line above.

Done.

[tommycli, 2014-10-30 23:23:45]

tommycli@chromium.org changed reviewers:
+ nasko@chromium.org

[tommycli, 2014-10-30 23:23:45]

nasko: May I have an OWNERS review for some ifdef changes?

Thanks.

[nasko, 2014-10-30 23:34:41]

Rubberstamp LGTM

[tommycli, 2014-10-30 23:55:56]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2014-10-30 23:56:12]

nasko: Thanks!

[commit-bot: I haz the power, 2014-10-30 23:56:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688343003/60001

[commit-bot: I haz the power, 2014-10-31 00:40:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-31 00:41:36]

Patchset 4 (id:??) landed as
https://crrev.com/e6633ca726043764a934add484216acc0b24445f
Cr-Commit-Position: refs/heads/master@{#302199}