Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 688343002: Revert of Disable WebRTC benchmark due to flakiness. (Closed)

Created:
6 years, 1 month ago by slamm
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable WebRTC benchmark due to flakiness. (patchset #1 id:1 of https://codereview.chromium.org/684023002/) Reason for revert: Committed fix for flakiness: https://codereview.chromium.org/688163003/ Original issue's description: > Disable WebRTC benchmark due to flakiness. > > TBR=tonyg@chromium.org, phoglund@chromium.org > BUG=428157 > > Committed: https://crrev.com/64709a0055eb91ceb5d29b4d6bfdaefa8380143d > Cr-Commit-Position: refs/heads/master@{#301753} TBR=phoglund@chromium.org,tonyg@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=428157 Committed: https://crrev.com/3d2ce69122a9d4757c8d6c5e0b50974654daf809 Cr-Commit-Position: refs/heads/master@{#302093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/webrtc.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
slamm
Created Revert of Disable WebRTC benchmark due to flakiness.
6 years, 1 month ago (2014-10-30 16:49:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688343002/1
6 years, 1 month ago (2014-10-30 16:49:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 16:50:35 UTC) #3
slamm
On 2014/10/30 16:49:09, slamm wrote: > Created Revert of Disable WebRTC benchmark due to flakiness. ...
6 years, 1 month ago (2014-10-30 16:51:02 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3d2ce69122a9d4757c8d6c5e0b50974654daf809 Cr-Commit-Position: refs/heads/master@{#302093}
6 years, 1 month ago (2014-10-30 16:51:11 UTC) #5
tonyg
6 years, 1 month ago (2014-10-30 16:56:55 UTC) #6
Message was sent while issue was closed.
On 2014/10/30 16:51:11, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3d2ce69122a9d4757c8d6c5e0b50974654daf809
> Cr-Commit-Position: refs/heads/master@{#302093}

Yep. Please swing back around to the flakiness dashboard though to verify that
it is, in fact, fixed.

http://build.chromium.org/f/chromium/flakiness/

Powered by Google App Engine
This is Rietveld 408576698