Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 688333002: Remove the Element.prefix setter (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Remove the Element.prefix setter Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/bka_hQuzAu0/tjD-GhJ6zDAJ Attribute::setPrefix() was unused and showed up in grep. BUG=431552 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185009

Patch Set 1 #

Patch Set 2 : remove tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -133 lines) Patch
D LayoutTests/fast/dom/Element/prefix-setter-exception.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/dom/Element/prefix-setter-exception-expected.txt View 1 1 chunk +0 lines, -29 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/node-prefix-setter-namespace-exception.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/node-prefix-setter-namespace-exception-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/script-tests/node-prefix-setter-namespace-exception.js View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/Attribute.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
philipj_slow
remove tests
6 years, 1 month ago (2014-10-31 12:39:52 UTC) #1
philipj_slow
PTAL
6 years, 1 month ago (2014-11-04 22:26:21 UTC) #3
pdr.
LGTM. Sorry for the delay (blinkon)
6 years, 1 month ago (2014-11-07 02:23:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688333002/20001
6 years, 1 month ago (2014-11-07 02:24:38 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/element-attribute-js-null-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-07 02:24:51 UTC) #8
philipj_slow
rebase
6 years, 1 month ago (2014-11-08 21:29:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688333002/40001
6 years, 1 month ago (2014-11-08 21:43:46 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 22:48:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185009

Powered by Google App Engine
This is Rietveld 408576698