Issue 68833004: Fix chicken and egg problem in composited bounds computation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68833004: Fix chicken and egg problem in composited bounds computation (Closed)

Created:
7 years, 1 month ago by Ian Vollick

Modified:
7 years, 1 month ago

Reviewers:
hartmanng, Julien - ping for review

CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix chicken and egg problem in composited bounds computation Inside RLC::rebuildCompositingTree we recursively walk the RenderLayers, and for each layer with a backing, we first update its composited bounds, THEN we update its geometry (naturally, since we need to know how big it is to figure out its geometry). Problem is, we update our draws-content status when we update geometry, and draws-content has an effect on our composited bounds. We've got a chicken and egg problem. We must, therefore, ensure that we have updated our draws-content status before updating our composited bounds. Note: depends on https://codereview.chromium.org/58543002 TEST=transforms/3d/point-mapping/3d-point-mapping-deep.html BUG=317698 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162032

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/CompositedLayerMapping.cpp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/68833004/90001

7 years, 1 month ago (2013-11-14 16:00:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/68833004/90001

7 years, 1 month ago (2013-11-14 16:09:34 UTC) #4

Message was sent while issue was closed.

Change committed as 162032

Expand Messages | Collapse Messages