Convert fast/multicol/column-rules to reftest.

Convert fast/multicol/column-rules to reftest.

Notable changes:

 * Used fixed multicol container width.
 * Specify column-gap.
 * Specify line-height.

R=mstensho@opera.com
BUG=386567
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184721

[andersr, 2014-10-30 15:23:10]

Note: this test looks pretty similar to column-count-with-rules.

[mstensho (USE GERRIT), 2014-10-30 20:13:39]

On 2014/10/30 15:23:10, andersr wrote:
> Note: this test looks pretty similar to column-count-with-rules.

Yes, but in this test you balance the columns, so I think it's worth keeping.

[mstensho (USE GERRIT), 2014-10-30 20:13:53]

lgtm

https://codereview.chromium.org/688323002/diff/1/LayoutTests/fast/multicol/co...
File LayoutTests/fast/multicol/column-rules.html (right):

https://codereview.chromium.org/688323002/diff/1/LayoutTests/fast/multicol/co...
LayoutTests/fast/multicol/column-rules.html:43: Line 30<br>
Could you be so evil and remove "Line 30<br>\n"? Then the number of lines is no
longer divisible by 3. :)

[mstensho (USE GERRIT), 2014-10-30 20:15:30]

On 2014/10/30 20:13:53, mstensho wrote:
> lgtm
> 
>
https://codereview.chromium.org/688323002/diff/1/LayoutTests/fast/multicol/co...
> File LayoutTests/fast/multicol/column-rules.html (right):
> 
>
https://codereview.chromium.org/688323002/diff/1/LayoutTests/fast/multicol/co...
> LayoutTests/fast/multicol/column-rules.html:43: Line 30<br>
> Could you be so evil and remove "Line 30<br>\n"? Then the number of lines is
no
> longer divisible by 3. :)

Bleh, ignore that. Then it would fail with old multicol, wouldn't it?

All I have to say then is lgtm with no nits.

[andersr, 2014-10-31 10:21:08]

On 2014/10/30 20:15:30, mstensho wrote:
> On 2014/10/30 20:13:53, mstensho wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/688323002/diff/1/LayoutTests/fast/multicol/co...
> > File LayoutTests/fast/multicol/column-rules.html (right):
> > 
> >
>
https://codereview.chromium.org/688323002/diff/1/LayoutTests/fast/multicol/co...
> > LayoutTests/fast/multicol/column-rules.html:43: Line 30<br>
> > Could you be so evil and remove "Line 30<br>\n"? Then the number of lines is
> no
> > longer divisible by 3. :)
> 
> Bleh, ignore that. Then it would fail with old multicol, wouldn't it?

Confirmed, it would fail in old multicol. The balancer would generously add some
bonus height to the multicol container.

[andersr, 2014-10-31 10:21:16]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-31 10:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688323002/1

[commit-bot: I haz the power, 2014-10-31 10:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 10:22:16]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #3 FAILED at 1016.
  1 out of 3 hunks FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
d76237a4eecb38935d61e28075264c0f35390d13..1797b0c0e854e35aa5802bef5736b398d64bc078
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -960,7 +960,6 @@ crbug.com/361729
fast/multicol/pagination-h-horizontal-tb.html [ Pass Failure ]
 # for the new multicol implementation.
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/border-padding-pagination.html [ Skip
]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/column-rules-stacking.html [ Skip ]
-crbug.com/386567 virtual/regionbasedmulticol/fast/multicol/column-rules.html [
Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/flipped-blocks-hit-test.html [ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/float-paginate-complex.html [ Skip ]
@@ -1010,7 +1009,6 @@ crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/table-margin-collapse
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/table-vertical-align.html [ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/unsplittable-inline-block.html [ Skip
]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/border-padding-pagination.html
[ Skip ]
-crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/column-rules.html [ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/float-paginate-complex.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/float-paginate.html [ Skip
]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/nested-columns.html [ Skip
]
@@ -1018,7 +1016,6 @@ crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/rules-wit
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-lr/unsplittable-inline-block.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/border-padding-pagination.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/break-properties.html [
Skip ]
-crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/column-rules.html [ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/float-paginate-complex.html
[ Skip ]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/float-paginate.html [ Skip
]
 crbug.com/386567
virtual/regionbasedmulticol/fast/multicol/vertical-rl/float-truncation.html [
Skip ]

[andersr, 2014-10-31 11:54:23]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-31 11:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688323002/20001

[commit-bot: I haz the power, 2014-10-31 12:59:10]

Committed patchset #2 (id:20001) as 184721