Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 6883221: Linux: clean up the usage of "use_cups" gyp switch: (Closed)

Created:
8 years, 1 month ago by Paweł Hajdan Jr.
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: clean up the usage of "use_cups" gyp switch: This CL removes duplication and fixes a build error on system with no CUPS. It uses cups-config instead of hardcoding flags. Also, it removes a superfluous dependency on gcrypt from chrome_browser.gypi. printing uses gcrypt explicitly, but chrome/browser doesn't. It was just blindly copy-pasted. I just extracted libgcrypt target to build/linux/system.gyp, and switched to libgcrypt-config instead of hardcoding flags. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83489

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -39 lines) Patch
M build/linux/system.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +3 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 3 chunks +38 lines, -16 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
Please review: thesting, sanjeevr: printing changes mark: gyp changes
8 years, 1 month ago (2011-04-28 09:47:10 UTC) #1
Paweł Hajdan Jr.
Sorry, a typo: thestig, sanjeevr: please review printing changes
8 years, 1 month ago (2011-04-28 09:48:44 UTC) #2
Lei Zhang
print_preview_handler.cc changes LGTM. Apologies for the mess from the copy + paste.
8 years, 1 month ago (2011-04-28 10:13:50 UTC) #3
Mark Mentovai
LG otherwise http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp File printing/printing.gyp (right): http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp#newcode208 printing/printing.gyp:208: '<!@(cups-config --cflags)', I’d like to avoid running ...
8 years, 1 month ago (2011-04-28 14:17:28 UTC) #4
Paweł Hajdan Jr.
http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp File printing/printing.gyp (right): http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp#newcode208 printing/printing.gyp:208: '<!@(cups-config --cflags)', On 2011/04/28 14:17:28, Mark Mentovai wrote: > ...
8 years, 1 month ago (2011-04-28 15:07:39 UTC) #5
Mark Mentovai
LGTM http://codereview.chromium.org/6883221/diff/5001/printing/printing.gyp File printing/printing.gyp (right): http://codereview.chromium.org/6883221/diff/5001/printing/printing.gyp#newcode216 printing/printing.gyp:216: 'libraries': [ I really only wanted to get ...
8 years, 1 month ago (2011-04-28 15:13:53 UTC) #6
sanjeevr
8 years, 1 month ago (2011-04-28 22:39:46 UTC) #7
thestig's LGTM for the print related code works for me.

Powered by Google App Engine
This is Rietveld 408576698