Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(78)

Issue 6883081: cryptohome: look for flag file to determine if init pkcs11 (Closed)

Created:
9 years, 7 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
gauravsh
CC:
chromium-os-reviews_chromium.org, Chris Masone, gauravsh, Will Drewry
Visibility:
Public.

Description

cryptohome: look for flag file to determine if init pkcs11 Change-Id: Ie2a43c98852b390c2a9089ccbe9304d60651810b BUG=none TEST= Try with secure_certificates on and off - verify successful boot, verify messages about trying pkcs11 init when on. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=08f77d6

Patch Set 1 #

Patch Set 2 : fix comment #

Total comments: 2

Patch Set 3 : respond to gaurav #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M cryptohomed.cc View 1 2 3 chunks +8 lines, -4 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
kmixter1
9 years, 7 months ago (2011-04-20 04:39:50 UTC) #1
gauravsh
http://codereview.chromium.org/6883081/diff/1002/cryptohomed.cc File cryptohomed.cc (right): http://codereview.chromium.org/6883081/diff/1002/cryptohomed.cc#newcode47 cryptohomed.cc:47: int enable_pkcs11_init = file_util::PathExists(FilePath(kEnablePkcs11Path)); Should you use platform.FileExists here?
9 years, 7 months ago (2011-04-20 18:25:02 UTC) #2
kmixter1
I'm inclined to go this path vs modifying the upstart script. Is this good to ...
9 years, 7 months ago (2011-04-20 19:00:58 UTC) #3
gauravsh
You may need to resync - I added a platform.FileExists() a few CLs ago. On ...
9 years, 7 months ago (2011-04-20 19:05:53 UTC) #4
kmixter1
PTAL
9 years, 7 months ago (2011-04-20 20:28:58 UTC) #5
gauravsh
http://codereview.chromium.org/6883081/diff/6001/cryptohomed.cc File cryptohomed.cc (right): http://codereview.chromium.org/6883081/diff/6001/cryptohomed.cc#newcode50 cryptohomed.cc:50: int enable_pkcs11_init = platform.FileExists(kEnablePkcs11Path); one suggestion: change this to ...
9 years, 7 months ago (2011-04-20 20:39:31 UTC) #6
gauravsh
9 years, 7 months ago (2011-04-20 20:39:46 UTC) #7
Other than the suggestion, LGTM.

Powered by Google App Engine
This is Rietveld 408576698