Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: fpdfsdk/include/javascript/JS_Value.h

Issue 688303003: For v8 Global Object, do not copy in CJS_Value constructor. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Value.cpp » ('j') | fpdfsdk/src/javascript/JS_Value.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/JS_Value.h
diff --git a/fpdfsdk/include/javascript/JS_Value.h b/fpdfsdk/include/javascript/JS_Value.h
index 030cdd5cf9e76c4d63d8672e14cfc865ca6eced4..79f4672ada7983859fda5c979aa3edfd764ca560 100644
--- a/fpdfsdk/include/javascript/JS_Value.h
+++ b/fpdfsdk/include/javascript/JS_Value.h
@@ -9,6 +9,8 @@
class CJS_Array;
class CJS_Date;
+class CJS_Document;
+class CJS_Object;
class CJS_Value
{
@@ -17,14 +19,15 @@ public:
CJS_Value(v8::Isolate* isolate, v8::Handle<v8::Value> pValue,FXJSVALUETYPE t);
CJS_Value(v8::Isolate* isolate, const int &iValue);
CJS_Value(v8::Isolate* isolate, const double &dValue);
- CJS_Value(v8::Isolate* isolate, const float &fValue);
+ CJS_Value(v8::Isolate* isolate, const float &fValue);
CJS_Value(v8::Isolate* isolate, const bool &bValue);
CJS_Value(v8::Isolate* isolate, JSFXObject);
CJS_Value(v8::Isolate* isolate, CJS_Object *);
+ CJS_Value(v8::Isolate* isolate, CJS_Document *);
CJS_Value(v8::Isolate* isolate, FX_LPCSTR pStr);
CJS_Value(v8::Isolate* isolate, FX_LPCWSTR pWstr);
CJS_Value(v8::Isolate* isolate, CJS_Array& array);
-
+
~CJS_Value();
void SetNull();
@@ -38,27 +41,24 @@ public:
operator double() const;
operator float() const;
operator CJS_Object *() const;
- //operator JSFXObject *() const;
operator v8::Handle<v8::Object>() const;
operator v8::Handle<v8::Array>() const;
operator CFX_WideString() const;
- //operator FX_WCHAR *() const;
operator CFX_ByteString() const;
v8::Handle<v8::Value> ToJSValue();
void operator = (int iValue);
- void operator = (bool bValue);
- void operator = (double);
- void operator = (float);
- void operator = (CJS_Object *);
+ void operator = (bool bValue);
+ void operator = (double);
+ void operator = (float);
+ void operator = (CJS_Object *);
void operator = (v8::Handle<v8::Object>);
-// void operator = (JSObject *);
void operator = (CJS_Array &);
void operator = (CJS_Date &);
- void operator = (FX_LPCWSTR pWstr);
- void operator = (FX_LPCSTR pStr);
+ void operator = (FX_LPCWSTR pWstr);
+ void operator = (FX_LPCSTR pStr);
void operator = (CJS_Value value);
-
+
FX_BOOL IsArrayObject() const;
FX_BOOL IsDateObject() const;
FXJSVALUETYPE GetType() const;
@@ -67,7 +67,7 @@ public:
FX_BOOL ConvertToDate(CJS_Date &) const;
v8::Isolate* GetIsolate() {return m_isolate;}
-protected:
+protected:
v8::Handle<v8::Value> m_pValue;
FXJSVALUETYPE m_eType;
v8::Isolate* m_isolate;
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Value.cpp » ('j') | fpdfsdk/src/javascript/JS_Value.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698