Issue 688303003: For v8 Global Object, do not copy in CJS_Value constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688303003: For v8 Global Object, do not copy in CJS_Value constructor. (Closed)

Created:
6 years, 1 month ago by Tom Sepez

Modified:
6 years, 1 month ago

Reviewers:
Bo Xu, jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

For v8 Global Object, do not copy in CJS_Value constructor. BUG=425129 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/f79a69c2513a9ee1431bd36c340e4b66bc2fd2d8

Patch Set 2 : whitespace #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -16 lines)			Patch
	M	fpdfsdk/include/javascript/JS_Value.h	View	1	4 chunks	+15 lines, -15 lines	0 comments	Download
	M	fpdfsdk/src/javascript/JS_Value.cpp	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bo Xu

lgtm https://codereview.chromium.org/688303003/diff/1/fpdfsdk/src/javascript/JS_Value.cpp File fpdfsdk/src/javascript/JS_Value.cpp (right): https://codereview.chromium.org/688303003/diff/1/fpdfsdk/src/javascript/JS_Value.cpp#newcode48 fpdfsdk/src/javascript/JS_Value.cpp:48: CJS_Value::CJS_Value(v8::Isolate* isolate, CJS_Object * pJsObj):m_isolate(isolate) Nit: CJS_Object* pJsObj

6 years, 1 month ago (2014-10-30 20:06:47 UTC) #3

Tom Sepez

6 years, 1 month ago (2014-10-30 20:23:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f79a69c2513a9ee1431bd36c340e4b66bc2fd2d8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 688303003: For v8 Global Object, do not copy in CJS_Value constructor. (Closed)

Description

Patch Set 1 #

Patch Set 2 : whitespace #

Messages