Issue 688243005: Reland "Fix stepping in for-loops."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688243005: Reland "Fix stepping in for-loops." (Closed)

Created:
6 years, 1 month ago by Yang

Modified:
6 years, 1 month ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -334 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/full-codegen.cc	View		5 chunks	+49 lines, -7 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/mips64/full-codegen-mips64.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/parser.cc	View	1	11 chunks	+21 lines, -18 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1	11 chunks	+12 lines, -14 lines	0 comments	Download
M	test/mjsunit/debug-step.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/es6/debug-stepnext-for.js	View	1	1 chunk	+116 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Yang

Please take a look. The fix is in patch set 2. As discussed offline, the ...

6 years, 1 month ago (2014-11-10 12:21:48 UTC) #1

Yang

6 years, 1 month ago (2014-11-12 08:26:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 25279 (presubmit successful).