sky/engine/core/rendering/RenderView.h - Issue 688213002: First pass at removing dead vertical writing mode code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderView.h

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderView.h

diff --git a/sky/engine/core/rendering/RenderView.h b/sky/engine/core/rendering/RenderView.h

index 32849b2ca45802b3daf9af8fb871ead83de425b5..8f45f3a89e2e61361b6e04f272497ad29248be62 100644

--- a/sky/engine/core/rendering/RenderView.h

+++ b/sky/engine/core/rendering/RenderView.h

@@ -69,7 +69,7 @@ public:

int viewWidth(IncludeScrollbarsInRect = ExcludeScrollbars) const;

int viewLogicalWidth() const

{

- return style()->isHorizontalWritingMode() ? viewWidth(ExcludeScrollbars) : viewHeight(ExcludeScrollbars);

+ return viewWidth(ExcludeScrollbars);

}

int viewLogicalHeight() const;

LayoutUnit viewLogicalHeightForPercentages() const;

« no previous file with comments | « sky/engine/core/rendering/RenderText.cpp ('k') | sky/engine/core/rendering/RenderView.cpp » ('j') | no next file with comments »