Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: sky/engine/core/rendering/InlineBox.cpp

Issue 688213002: First pass at removing dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/EventHandler.cpp ('k') | sky/engine/core/rendering/InlineFlowBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/InlineBox.cpp
diff --git a/sky/engine/core/rendering/InlineBox.cpp b/sky/engine/core/rendering/InlineBox.cpp
index da06758f913b190afe59497dd05ea785deb1b08d..ee657f6a3c91eb134efc9252f7fa473757be0c59 100644
--- a/sky/engine/core/rendering/InlineBox.cpp
+++ b/sky/engine/core/rendering/InlineBox.cpp
@@ -314,41 +314,30 @@ void InlineBox::clearKnownToHaveNoOverflow()
FloatPoint InlineBox::locationIncludingFlipping()
{
- if (!renderer().style()->isFlippedBlocksWritingMode())
- return FloatPoint(x(), y());
- RenderBlockFlow& block = root().block();
- if (block.style()->isHorizontalWritingMode())
- return FloatPoint(x(), block.height() - height() - y());
-
- return FloatPoint(block.width() - width() - x(), y());
+ // FIXME(sky): remove
+ return FloatPoint(x(), y());
}
void InlineBox::flipForWritingMode(FloatRect& rect)
{
- if (!renderer().style()->isFlippedBlocksWritingMode())
- return;
- root().block().flipForWritingMode(rect);
+ // FIXME(sky): remove
}
FloatPoint InlineBox::flipForWritingMode(const FloatPoint& point)
{
- if (!renderer().style()->isFlippedBlocksWritingMode())
- return point;
- return root().block().flipForWritingMode(point);
+ // FIXME(sky): remove
+ return point;
}
void InlineBox::flipForWritingMode(LayoutRect& rect)
{
- if (!renderer().style()->isFlippedBlocksWritingMode())
- return;
- root().block().flipForWritingMode(rect);
+ // FIXME(sky): remove
}
LayoutPoint InlineBox::flipForWritingMode(const LayoutPoint& point)
{
- if (!renderer().style()->isFlippedBlocksWritingMode())
- return point;
- return root().block().flipForWritingMode(point);
+ // FIXME(sky): remove
+ return point;
}
} // namespace blink
« no previous file with comments | « sky/engine/core/page/EventHandler.cpp ('k') | sky/engine/core/rendering/InlineFlowBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698