Move writing information to the lockbox after registering with the DM server.

Move writing information to the lockbox after registering with the DM server.

BUG=14285
TEST=Manual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83012

[Mattias Nissler (ping if slow), 2011-04-19 12:15:25]

Generally looks good, except for the part about having
DevicePolicyIdentityStrategy trigger the policy fetch as discussed offline.

http://codereview.chromium.org/6882038/diff/1/chrome/browser/chromeos/login/e...
File chrome/browser/chromeos/login/enterprise_enrollment_screen.cc (right):

http://codereview.chromium.org/6882038/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/enterprise_enrollment_screen.cc:133: LOG(ERROR) <<
"### Auth done!";
Be sure to remove this or make it a VLOG() before committing.

http://codereview.chromium.org/6882038/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/enterprise_enrollment_screen.cc:155: LOG(ERROR) <<
"### State change : " << state;
same here.

http://codereview.chromium.org/6882038/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/enterprise_enrollment_screen.cc:235: LOG(ERROR) <<
"### Lock it!";
And here!

http://codereview.chromium.org/6882038/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/enterprise_enrollment_screen.cc:242:
connector->cloud_policy_subsystem()->SendPolicyRequest();
This should probably be connector->EnablePolicy(), which will then forward the
call to the identity strategy, so it can send the OnDeviceTokenChanged()
notification the controller.

http://codereview.chromium.org/6882038/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/enterprise_enrollment_screen.cc:243: LOG(ERROR) <<
"### Locked!";
And here.

http://codereview.chromium.org/6882038/diff/1/chrome/browser/policy/cloud_pol...
File chrome/browser/policy/cloud_policy_controller.h (right):

http://codereview.chromium.org/6882038/diff/1/chrome/browser/policy/cloud_pol...
chrome/browser/policy/cloud_policy_controller.h:50: void
StopAfterTokenFetch(bool enabled);
Let's go through the identity strategy, which is device-policy specific.

[pastarmovj, 2011-04-20 14:27:21]

Moved the logic to the identity strategy as discussed. Trybots are running too.

[Mattias Nissler (ping if slow), 2011-04-20 14:32:49]

good to go if trybots agree.

http://codereview.chromium.org/6882038/diff/5005/chrome/browser/policy/device...
File chrome/browser/policy/device_policy_identity_strategy.cc (right):

http://codereview.chromium.org/6882038/diff/5005/chrome/browser/policy/device...
chrome/browser/policy/device_policy_identity_strategy.cc:87: void
DevicePolicyIdentityStrategy::FetchPolicy() {
DCHECK(!device_token_.empty())

http://codereview.chromium.org/6882038/diff/5005/chrome/browser/policy/device...
File chrome/browser/policy/device_policy_identity_strategy.h (right):

http://codereview.chromium.org/6882038/diff/5005/chrome/browser/policy/device...
chrome/browser/policy/device_policy_identity_strategy.h:36: // Initiates a
policy fetch after a successful device registration.
Document that the device token needs to have been set previously.

[Mattias Nissler (ping if slow), 2011-04-20 14:51:20]

LGTM pending trybot happiness.

[Mattias Nissler (ping if slow), 2011-04-20 15:12:43]

http://codereview.chromium.org/6882038/diff/5007/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/background_view.cc (right):

http://codereview.chromium.org/6882038/diff/5007/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/background_view.cc:499: case
policy::CloudPolicySubssytem::TOKEN_FETCHED:
You have a typo here :)

[Mattias Nissler (ping if slow), 2011-04-26 15:18:57]

On 2011/04/20 15:12:43, Mattias Nissler wrote:
>
http://codereview.chromium.org/6882038/diff/5007/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/background_view.cc (right):
> 
>
http://codereview.chromium.org/6882038/diff/5007/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/background_view.cc:499: case
> policy::CloudPolicySubssytem::TOKEN_FETCHED:
> You have a typo here :)

Oh, and btw.: To reference bugs in CrOS, you should specify them as
chromium-os:XYZ