Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 688183002: Refactor TouchTransformerConverter to allow support for Ozone (Closed)

Created:
6 years, 1 month ago by dnicoara
Modified:
6 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@mv-touch-transformer
Project:
chromium
Visibility:
Public.

Description

Refactor TouchTransformerConverter to allow support for Ozone In Ozone the touch events are received in device coordinates. This change consolidates the different transformations into one function and makes it use the touchscreen size when computing the transformation for Ozone and the framebuffer size for X11. BUG=425258 TESTS=Manually verified that X11 in single, mirror, extended and docked mode work with external touchscreen. Committed: https://crrev.com/8c3bd1e68124be19b17420144b4b76ece0c87035 Cr-Commit-Position: refs/heads/master@{#302135}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -116 lines) Patch
M ash/ash.gyp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ash/shell.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 4 chunks +4 lines, -6 lines 0 comments Download
M ash/touch/touch_transformer_controller.h View 2 chunks +13 lines, -11 lines 0 comments Download
M ash/touch/touch_transformer_controller.cc View 6 chunks +63 lines, -79 lines 0 comments Download
M ash/touch/touch_transformer_controller_unittest.cc View 8 chunks +61 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dnicoara
PTAL derat@ for OWNERS
6 years, 1 month ago (2014-10-30 16:34:21 UTC) #2
Daniel Erat
lgtm as an owner, although i didn't review the math
6 years, 1 month ago (2014-10-30 16:38:08 UTC) #3
dnicoara
On 2014/10/30 16:38:08, Daniel Erat wrote: > lgtm as an owner, although i didn't review ...
6 years, 1 month ago (2014-10-30 16:49:19 UTC) #4
Yufeng Shen (Slow to review)
On 2014/10/30 16:49:19, dnicoara wrote: > On 2014/10/30 16:38:08, Daniel Erat wrote: > > lgtm ...
6 years, 1 month ago (2014-10-30 17:19:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688183002/20001
6 years, 1 month ago (2014-10-30 18:31:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 19:53:47 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:54:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c3bd1e68124be19b17420144b4b76ece0c87035
Cr-Commit-Position: refs/heads/master@{#302135}

Powered by Google App Engine
This is Rietveld 408576698