Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: ui/events/devices/device_util_linux.cc

Issue 688163004: Move X11 device processing to worker threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-blocking-touchscreen
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/devices/device_util_linux.cc
diff --git a/ui/events/devices/device_util_linux.cc b/ui/events/devices/device_util_linux.cc
index 89247f110a9e50eacb490f2257f2d539fa624788..a9212ed45a5a8e2ebdc79ff52f541e1f876fd3c7 100644
--- a/ui/events/devices/device_util_linux.cc
+++ b/ui/events/devices/device_util_linux.cc
@@ -12,6 +12,9 @@
namespace ui {
+// We consider the touchscreen to be internal if it is an I2c device. We search
+// all the dev input nodes registered by I2C devices to see if we can find
+// eventXXX.
bool IsTouchscreenInternal(const base::FilePath& path) {
std::string event_node = path.BaseName().value();
sadrul 2014/11/06 21:05:27 Can you add CHECK_NE(TYPE_UI, MessageLoop::current
dnicoara 2014/11/10 19:34:51 Worker threads don't have a message loop. Is there
sadrul 2014/11/11 18:29:51 Perhaps CHECK(!MessageLoopForUI::IsCurrent())?
if (event_node.empty() || !StartsWithASCII(event_node, "event", false))
« no previous file with comments | « no previous file | ui/events/platform/x11/x11_event_source.h » ('j') | ui/events/platform/x11/x11_hotplug_event_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698