Combine nameFontStyleProc and FindByNameStyle.

Combine nameFontStyleProc and FindByNameStyle.

These two functions do the same thing, combine them.

Committed: https://skia.googlesource.com/skia/+/967937c282ebdd9044fe1cfc8744b0697cbd64df

[bungeman-skia, 2014-10-29 21:49:28]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[mtklein, 2014-10-29 22:00:03]

lgtm

https://codereview.chromium.org/688133003/diff/1/src/ports/SkFontHost_mac.cpp
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/688133003/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:595: const SkTypeface_Mac* cachedMacFace =
reinterpret_cast<SkTypeface_Mac*>(cachedFace);
This is a tangent, but should be these can both be static_cast?

https://codereview.chromium.org/688133003/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:598: return requested->fStyle == cachedStyle
Might write "cachedStyle == requested->fStyle" for symmetry with the next line?

[bungeman-skia, 2014-10-30 16:56:40]

https://codereview.chromium.org/688133003/diff/1/src/ports/SkFontHost_mac.cpp
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/688133003/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:595: const SkTypeface_Mac* cachedMacFace =
reinterpret_cast<SkTypeface_Mac*>(cachedFace);
On 2014/10/29 22:00:02, mtklein wrote:
> This is a tangent, but should be these can both be static_cast?

Done.

https://codereview.chromium.org/688133003/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:598: return requested->fStyle == cachedStyle
On 2014/10/29 22:00:02, mtklein wrote:
> Might write "cachedStyle == requested->fStyle" for symmetry with the next
line?

Done.

[bungeman-skia, 2014-10-30 16:56:54]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-10-30 16:57:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688133003/20001

[commit-bot: I haz the power, 2014-10-30 18:49:36]

Committed patchset #2 (id:20001) as 967937c282ebdd9044fe1cfc8744b0697cbd64df