Fix VM not accepting static methods for Isolate.spawn.

tests/isolate/static_function_test.dart

Index: tests/isolate/static_function_test.dart
diff --git a/tests/isolate/static_function_test.dart b/tests/isolate/static_function_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..2d0922d4ec8c7bb849b817a378162eaad8679867
--- /dev/null
+++ b/tests/isolate/static_function_test.dart
@@ -0,0 +1,70 @@
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Test starting isolate with static functions (and toplevel ones, for sanity).
+
+library static_function_test;
+import 'dart:isolate';
+import 'dart:async';
+import 'static_function_lib.dart' as lib;
+import '../../pkg/unittest/lib/unittest.dart';
+
+void function(SendPort port) { port.send("TOP"); }
+void _function(SendPort port) { port.send("_TOP"); }
+
+var staticClosure = (SendPort port) { port.send("WHAT?"); };
+get dynamicClosure => (SendPort port) { port.send("WHAT??"); };
+
+class C {
+  static void function(SendPort port) { port.send("YES"); }
+  static void _function(SendPort port) { port.send("PRIVATE"); }
+  void instanceMethod(SendPort port) { port.send("INSTANCE WHAT?"); }
+}
+
+class _C {
+  static void function(SendPort port) { port.send("_YES"); }
+  static void _function(SendPort port) { port.send("_PRIVATE"); }
+}
+
+void spawnTest(name, function, response) {
+  test(name, () {
+    ReceivePort r = new ReceivePort();
+      Isolate.spawn(function, r.sendPort);
+      r.listen(expectAsync1((v) {
+        expect(v, response);
+        r.close();
+      }));
+  });
+}
+
+void throwsTest(name, function) {
+  test("throws on $name", () {
+    expect(() { Isolate.spawn(function, null); }, throws);
+  });
+}
+
+void main() {
+  // Sanity check.
+  spawnTest("function", function, "TOP");
+  spawnTest("_function", _function, "_TOP");
+  spawnTest("lib.function", lib.function, "LIBTOP");
+  spawnTest("lib._function", lib.privateFunction, "_LIBTOP");
+
+  // Local static functions.
+  spawnTest("class.function", C.function, "YES");
+  spawnTest("class._function", C._function, "PRIVATE");
+  spawnTest("_class._function", _C.function, "_YES");
+  spawnTest("_class._function", _C._function, "_PRIVATE");
+
+  // Imported static functions.
+  spawnTest("lib.class.function", lib.C.function, "LIB");
+  spawnTest("lib.class._function", lib.C.privateFunction, "LIBPRIVATE");
+  spawnTest("lib._class._function", lib.privateClassFunction, "_LIB");
+  spawnTest("lib._class._function", lib.privateClassAndFunction, "_LIBPRIVATE");
+
+  // Negative tests
+  throwsTest("static closure", staticClosure);

[Lasse Reichstein Nielsen, 2013/11/12 07:34:05]

This test, and the next one, fails in the VM.
I'll try to figure out how to distinguish these from declared top-level
functions.

+  throwsTest("dynamic closure", dynamicClosure);
+  throwsTest("instance method", new C().instanceMethod);
+}