Fix VM not accepting static methods for Isolate.spawn.

runtime/lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 197 matching lines @@
   state->isolate()->set_spawn_data(reinterpret_cast<uword>(state));
   if (state->isolate()->is_runnable()) {
     state->isolate()->Run();
   }
 
   return port.raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(Isolate_spawnFunction, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, closure, arguments->NativeArgAt(0));

[Ivan Posva, 2013/11/19 22:20:15]

This whole control flow can be simplified. Feel free to address or add a
TODO(iposva):

if (closure.IsClosure()) {
  const Function& func = Function::Handle(Closure::function(closure));
  if (func.IsImplicitClosureFunction() && func.is_static()) {
    ASSERT(...)
    return Spawn(...);
  }
}
Exceptions::ThrowArgumentException(...);
return Object::null();

[Lasse Reichstein Nielsen, 2013/11/20 09:09:10]

Done. Just rearranged the blocks, so if you know a way to simplyfy the "#ifdef
DEBUG" block into a single ASSERT, you can still do that.

   bool throw_exception = false;
   Function& func = Function::Handle();
   if (closure.IsClosure()) {
     func = Closure::function(closure);
-    const Class& cls = Class::Handle(func.Owner());
-    if (!func.IsClosureFunction() || !func.is_static() || !cls.IsTopLevel()) {
+    if (!(func.IsImplicitClosureFunction() && func.is_static())) {
       throw_exception = true;
     }
   } else {
     throw_exception = true;
   }
   if (throw_exception) {
     const String& msg = String::Handle(String::New(
-        "Isolate.spawn expects to be passed a top-level function"));
+        "Isolate.spawn expects to be passed a static or top-level function"));
     Exceptions::ThrowArgumentError(msg);
   }
 
 #if defined(DEBUG)
   Context& ctx = Context::Handle();
   ctx = Closure::context(closure);
   ASSERT(ctx.num_variables() == 0);
 #endif
 
   return Spawn(arguments, new IsolateSpawnState(func));
@@ skipping 26 matching lines @@
 
   // The control port is being accessed as a regular port from Dart code. This
   // is most likely due to the _startIsolate code in dart:isolate. Account for
   // this by increasing the number of open control ports.
   isolate->message_handler()->increment_control_ports();
 
   return port.raw();
 }
 
 }  // namespace dart