Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 688123003: [unpacker] Whitelist the new ZIP unpacker for display_in_launcher feature. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[unpacker] Whitelist the new ZIP unpacker for display_in_launcher feature. The app doesn't have any UI, so it shouldn't show in the launcher. It can't be an extension because it uses file handlers. We're going to remove this whitelist once file handlers availability to extensions is resolved. TEST=Tested manually that the icon is gone. BUG=427747 Committed: https://crrev.com/7d9752185b04ee431f9f10e20744b376a1f3fab8 Cr-Commit-Position: refs/heads/master@{#302238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@benwells: PTAL. Thanks.
6 years, 1 month ago (2014-10-30 08:31:43 UTC) #2
benwells
is this a component app?
6 years, 1 month ago (2014-10-30 22:23:10 UTC) #3
mtomasz
On 2014/10/30 22:23:10, benwells wrote: > is this a component app? External component.
6 years, 1 month ago (2014-10-30 23:33:50 UTC) #4
benwells
lgtm
6 years, 1 month ago (2014-10-31 06:16:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688123003/1
6 years, 1 month ago (2014-10-31 06:23:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 07:03:59 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 07:24:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d9752185b04ee431f9f10e20744b376a1f3fab8
Cr-Commit-Position: refs/heads/master@{#302238}

Powered by Google App Engine
This is Rietveld 408576698