[Sync] Fix race condition in P2PNotifier with sending notifications

chrome/browser/sync/notifier/p2p_notifier.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/notifier/p2p_notifier.h"
 
 #include "base/message_loop_proxy.h"
 #include "chrome/browser/sync/notifier/sync_notifier_observer.h"
 #include "chrome/browser/sync/protocol/service_constants.h"
 #include "chrome/browser/sync/syncable/model_type_payload_map.h"
@@ skipping 76 matching lines @@
   enabled_types_ = types;
   MaybeEmitNotification();
 }
 
 void P2PNotifier::SendNotification() {
   CheckOrSetValidThread();
   VLOG(1) << "Sending XMPP notification...";
   notifier::Notification notification;
   notification.channel = kSyncNotificationChannel;
   notification.data = kSyncNotificationData;
-  bool success = talk_mediator_->SendNotification(notification);
-  if (success) {
-    VLOG(1) << "Sent XMPP notification";
-  } else {
-    VLOG(1) << "Could not send XMPP notification";
-  }
+  talk_mediator_->SendNotification(notification);
 }
 
 void P2PNotifier::OnNotificationStateChange(bool notifications_enabled) {
   CheckOrSetValidThread();
   notifications_enabled_ = notifications_enabled;
   FOR_EACH_OBSERVER(SyncNotifierObserver, observer_list_,
       OnNotificationStateChange(notifications_enabled_));
   MaybeEmitNotification();
 }
 
 void P2PNotifier::OnIncomingNotification(
     const notifier::Notification& notification) {
   CheckOrSetValidThread();
   VLOG(1) << "Sync received P2P notification.";
   if (notification.channel != kSyncNotificationChannel) {
-    LOG(WARNING) << "Notification fron unexpected source: "
+    LOG(WARNING) << "Notification from unexpected source: "
                  << notification.channel;
   }
   MaybeEmitNotification();
 }
 
 void P2PNotifier::OnOutgoingNotification() {}
 
 void P2PNotifier::MaybeEmitNotification() {
   if (!logged_in_) {
     VLOG(1) << "Not logged in yet -- not emitting notification";
@@ skipping 17 matching lines @@
 void P2PNotifier::CheckOrSetValidThread() {
   if (method_message_loop_proxy_) {
     DCHECK(method_message_loop_proxy_->BelongsToCurrentThread());
   } else {
     method_message_loop_proxy_ =
         base::MessageLoopProxy::CreateForCurrentThread();
   }
 }
 
 }  // namespace sync_notifier