Issue 688103002: Fix bug introduced in https://codereview.chromium.org/679103004/,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688103002: Fix bug introduced in https://codereview.chromium.org/679103004/, (Closed)

Created:
6 years, 1 month ago by mmenke

Modified:
6 years, 1 month ago

Reviewers:
mef

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix bug introduced in https://codereview.chromium.org/679103004/, here get() was used instead of release() on a scoped_ptr in NetLogLogger. BUG=426918 Committed: https://crrev.com/bbd65918d052f5095299676f9b0800506e7ae2c0 Cr-Commit-Position: refs/heads/master@{#301924}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/base/net_log_logger.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688103002/1

6 years, 1 month ago (2014-10-29 19:56:04 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 20:57:39 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bbd65918d052f5095299676f9b0800506e7ae2c0
Cr-Commit-Position: refs/heads/master@{#301924}