src/x64/lithium-codegen-x64.cc - Issue 6881003: Prevent deopt when assigning double values to typed arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 6881003: Prevent deopt when assigning double values to typed arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixes to make ia32 tests run Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index c242874c52b61b31e2c6cc20d686dbcb27911f01..6a2deea7852c96ea64f81f47e99e636f561e20c9 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -1549,7 +1549,7 @@ void LCodeGen::DoIsNullAndBranch(LIsNullAndBranch* instr) {

int false_block = chunk_->LookupDestination(instr->false_block_id());

- if (instr->hydrogen()->representation().IsSpecialization() ||

+ if (instr->hydrogen()->representation().IsUntagged() ||

instr->hydrogen()->type().IsSmi()) {

// If the expression is known to untagged or smi, then it's definitely

// not null, and it can't be a an undetectable object.