Issue 688043002: remove now unused (by Chrome) ifdef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688043002: remove now unused (by Chrome) ifdef (Closed)

Created:
6 years, 1 month ago by humper

Modified:
6 years, 1 month ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

remove now unused (by Chrome) ifdef BUG=skia: Committed: https://skia.googlesource.com/skia/+/9c30ea4c8654cc251ce243df4df97e30dab23ebb

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	src/core/SkBitmapProcState.cpp	View		1 chunk	+0 lines, -5 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

reed1

lgtm https://codereview.chromium.org/688043002/diff/1/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/688043002/diff/1/src/core/SkBitmapProcState.cpp#newcode147 src/core/SkBitmapProcState.cpp:147: float roundedDestWidth = SkScalarRoundToScalar(trueDestWidth); future nit: these should ...

6 years, 1 month ago (2014-10-29 17:35:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688043002/1

6 years, 1 month ago (2014-10-29 18:05:35 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 19:41:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 9c30ea4c8654cc251ce243df4df97e30dab23ebb

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages