Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: profiling.py

Issue 6880335: Fix error when checking the request arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/chromium-status
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: profiling.py
diff --git a/profiling.py b/profiling.py
index acb1258b57ae7ba44dbe4e998c356c350165ffd1..22662b1feda0af6612edaf1a13e67cf30ba25eef 100644
--- a/profiling.py
+++ b/profiling.py
@@ -84,8 +84,9 @@ class Profiling(BasePage):
blacklist = ('timestamp', 'executable', 'first_arg')
required = ('argv', 'duration', 'platform', 'domain')
accepted_keys = list(set(ProfileReport.properties()) - set(blacklist))
+ arguments = self.request.arguments()
kwargs = dict(
- (k, self.request.get(k)) for k in accepted_keys if k in self.request)
+ (k, self.request.get(k)) for k in accepted_keys if k in arguments)
if not all(kwargs.get(k, None) for k in required):
logging.info('missing required keys. %r' % kwargs)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698