Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 688023002: text-transform causes incorrect text placement in svg (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

text-transform causes incorrect text placement in svg Override originalText method in RenderSVGInlineText so that RenderText::transformText uses it and gets the text with SVG whitespace rules applied. BUG=327606 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184655

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add test #

Total comments: 1

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
A LayoutTests/svg/text/text-transform-ws-rules.svg View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-transform-ws-rules-expected.svg View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.cpp View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-10-29 17:39:29 UTC) #2
fs
LGTM (a bit uneasy about hiding the whitespace-mangling, but it sort of makes sense as ...
6 years, 1 month ago (2014-10-30 12:31:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688023002/60001
6 years, 1 month ago (2014-10-30 14:25:47 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 15:40:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 184655

Powered by Google App Engine
This is Rietveld 408576698