Issue 6880219: Fix crash with webRequest.event.addListener when provided an invalid URL

Issue 6880219: Fix crash with webRequest.event.addListener when provided an invalid URL (Closed)

Created:
9 years, 8 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
battre

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash with webRequest.event.addListener when provided an invalid URL pattern. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83208

Patch Set 3 : oops #

Total comments: 4

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -20 lines)			Patch
M	chrome/browser/extensions/extension_webrequest_api.cc	View	1 2	5 chunks	+23 lines, -6 lines	2 comments	Download
M	chrome/browser/extensions/extension_webrequest_api_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_webrequest_api_constants.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webrequest/api/test.html	View	1	1 chunk	+24 lines, -14 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

battre

LGTM http://codereview.chromium.org/6880219/diff/2002/chrome/browser/extensions/extension_webrequest_api.cc File chrome/browser/extensions/extension_webrequest_api.cc (right): http://codereview.chromium.org/6880219/diff/2002/chrome/browser/extensions/extension_webrequest_api.cc#newcode676 chrome/browser/extensions/extension_webrequest_api.cc:676: // the renderer to believe the listener exists, ...

9 years, 8 months ago (2011-04-27 09:45:31 UTC) #2

Matt Perry

9 years, 8 months ago (2011-04-27 19:45:59 UTC) #3

http://codereview.chromium.org/6880219/diff/2002/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_webrequest_api.cc (right):

http://codereview.chromium.org/6880219/diff/2002/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_webrequest_api.cc:676: // the renderer to
believe the listener exists, while the browser does not.
On 2011/04/27 09:45:31, battre wrote:
> nit: grammar in "the renderer to believe"

Done.

http://codereview.chromium.org/6880219/diff/2002/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/webrequest/api/test.html (right):

http://codereview.chromium.org/6880219/diff/2002/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/webrequest/api/test.html:68: {urls:
["badpattern://*"]});
On 2011/04/27 09:45:31, battre wrote:
> optional: do you want to send a removeListener instantly after the
addListener?

Done.

Expand Messages | Collapse Messages