Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 6880051: [Sync] Re-re-reland 81454. This time with fixed waitable event usage. (Closed)

Created:
9 years, 8 months ago by Nicolas Zea
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Re-re-reland 81454. This time with fixed waitable event usage. Original codereview: http://codereview.chromium.org/6811003 BUG=77964, 79410 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82310

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix intialization, reduce timeouts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 1 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
9 years, 8 months ago (2011-04-19 23:29:13 UTC) #1
akalin
LGTM I assume this diff is based off the original CL, but what you'll land ...
9 years, 8 months ago (2011-04-20 00:18:13 UTC) #2
Nicolas Zea
Fixed initialization of watiable event, committing once trybots go green. http://codereview.chromium.org/6880051/diff/1/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc File chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc (right): http://codereview.chromium.org/6880051/diff/1/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc#newcode188 ...
9 years, 8 months ago (2011-04-20 00:41:55 UTC) #3
commit-bot: I haz the power
9 years, 8 months ago (2011-04-20 01:31:06 UTC) #4
Can't apply patch for file
chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc.
patching file
chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc
Hunk #1 FAILED at 116.
Hunk #2 FAILED at 176.
Hunk #3 FAILED at 207.
3 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc.rej

Powered by Google App Engine
This is Rietveld 408576698