Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: src/ic-inl.h

Issue 6880010: Merge (7265, 7271] from bleeding_edge to experimental/gc branch.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 34
35 namespace v8 { 35 namespace v8 {
36 namespace internal { 36 namespace internal {
37 37
38 38
39 Address IC::address() { 39 Address IC::address() {
40 // Get the address of the call. 40 // Get the address of the call.
41 Address result = pc() - Assembler::kCallTargetAddressOffset; 41 Address result = pc() - Assembler::kCallTargetAddressOffset;
42 42
43 #ifdef ENABLE_DEBUGGER_SUPPORT 43 #ifdef ENABLE_DEBUGGER_SUPPORT
44 Debug* debug = Isolate::Current()->debug();
44 // First check if any break points are active if not just return the address 45 // First check if any break points are active if not just return the address
45 // of the call. 46 // of the call.
46 if (!Debug::has_break_points()) return result; 47 if (!debug->has_break_points()) return result;
47 48
48 // At least one break point is active perform additional test to ensure that 49 // At least one break point is active perform additional test to ensure that
49 // break point locations are updated correctly. 50 // break point locations are updated correctly.
50 if (Debug::IsDebugBreak(Assembler::target_address_at(result))) { 51 if (debug->IsDebugBreak(Assembler::target_address_at(result))) {
51 // If the call site is a call to debug break then return the address in 52 // If the call site is a call to debug break then return the address in
52 // the original code instead of the address in the running code. This will 53 // the original code instead of the address in the running code. This will
53 // cause the original code to be updated and keeps the breakpoint active in 54 // cause the original code to be updated and keeps the breakpoint active in
54 // the running code. 55 // the running code.
55 return OriginalCodeAddress(); 56 return OriginalCodeAddress();
56 } else { 57 } else {
57 // No break point here just return the address of the call. 58 // No break point here just return the address of the call.
58 return result; 59 return result;
59 } 60 }
60 #else 61 #else
(...skipping 18 matching lines...) Expand all
79 #ifdef DEBUG 80 #ifdef DEBUG
80 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark 81 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
81 // ICs as strict mode. The strict-ness of the IC must be preserved. 82 // ICs as strict mode. The strict-ness of the IC must be preserved.
82 Code* old_target = GetTargetAtAddress(address); 83 Code* old_target = GetTargetAtAddress(address);
83 if (old_target->kind() == Code::STORE_IC || 84 if (old_target->kind() == Code::STORE_IC ||
84 old_target->kind() == Code::KEYED_STORE_IC) { 85 old_target->kind() == Code::KEYED_STORE_IC) {
85 ASSERT(old_target->extra_ic_state() == target->extra_ic_state()); 86 ASSERT(old_target->extra_ic_state() == target->extra_ic_state());
86 } 87 }
87 #endif 88 #endif
88 Assembler::set_target_address_at(address, target->instruction_start()); 89 Assembler::set_target_address_at(address, target->instruction_start());
89 IncrementalMarking::RecordWriteOf(target); 90 // TODO(gc) ISOLATES MERGE code object should have heap() accessor.
91 target->GetHeap()->incremental_marking()->RecordWriteOf(target);
90 } 92 }
91 93
92 94
93 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 95 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object,
94 JSObject* holder) { 96 JSObject* holder) {
95 if (object->IsJSObject()) { 97 if (object->IsJSObject()) {
96 return GetCodeCacheForObject(JSObject::cast(object), holder); 98 return GetCodeCacheForObject(JSObject::cast(object), holder);
97 } 99 }
98 // If the object is a value, we use the prototype map for the cache. 100 // If the object is a value, we use the prototype map for the cache.
99 ASSERT(object->IsString() || object->IsNumber() || object->IsBoolean()); 101 ASSERT(object->IsString() || object->IsNumber() || object->IsBoolean());
(...skipping 21 matching lines...) Expand all
121 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) { 123 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) {
122 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype()); 124 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype());
123 ASSERT(map_owner->IsJSObject()); 125 ASSERT(map_owner->IsJSObject());
124 return JSObject::cast(map_owner); 126 return JSObject::cast(map_owner);
125 } 127 }
126 128
127 129
128 } } // namespace v8::internal 130 } } // namespace v8::internal
129 131
130 #endif // V8_IC_INL_H_ 132 #endif // V8_IC_INL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698