Issue 687973004: Add VersionRange.hashCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687973004: Add VersionRange.hashCode. (Closed)

Created:
6 years, 1 month ago by nweiz

Modified:
6 years, 1 month ago

Reviewers:
Bob Nystrom

Base URL:
git@github.com:dart-lang/pub_semver@master

Visibility:
Public.

Description

Add VersionRange.hashCode. Closes #4 R=rnystrom@google.com Committed: 182d55d7207e3af5e76e96834fa7cf63c55ce09a

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -1 line)
M	CHANGELOG.md	View	1 chunk	+2 lines, -0 lines	0 comments
M	lib/src/version_range.dart	View	1 chunk	+3 lines, -0 lines	1 comment
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 (id:1) manually as 182d55d7207e3af5e76e96834fa7cf63c55ce09a (presubmit successful).

6 years, 1 month ago (2014-10-29 22:49:58 UTC) #3

Bob Nystrom

6 years, 1 month ago (2014-10-30 16:45:24 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/687973004/diff/1/lib/src/version_range.dart
File lib/src/version_range.dart (right):

https://codereview.chromium.org/687973004/diff/1/lib/src/version_range.dart#n...
lib/src/version_range.dart:70: (includeMin.hashCode * 5) ^ (includeMax.hashCode
* 7);
Idle thought: these multiplications can push the result to a bigint. Do we care
about that?

Expand Messages | Collapse Messages