Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 687943002: Removed test case having scrollbar issues on Mac. (Closed)

Created:
6 years, 1 month ago by rune
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed test case having scrollbar issues on Mac. For some reason the generated scrollbar pseudo element count was different on Mac, although the test passed on the Mac bot when landing. I've removed the test for :single-button/:double-button as the test coverage by the other pseudo classes should be enough. R=leviw@chromium.org BUG=427953 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185036

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/invalidation/scrollbar-pseudo-classes.html View 3 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/css/invalidation/scrollbar-pseudo-classes-expected.html View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
6 years, 1 month ago (2014-10-29 11:04:26 UTC) #1
leviw_travelin_and_unemployed
LGTM.
6 years, 1 month ago (2014-11-05 23:32:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687943002/1
6 years, 1 month ago (2014-11-05 23:32:34 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-05 23:32:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687943002/20001
6 years, 1 month ago (2014-11-10 12:47:31 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 13:51:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185036

Powered by Google App Engine
This is Rietveld 408576698