Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 68793008: MIPS: Fixed crashes exposed though fuzzing. (Closed)

Created:
7 years, 1 month ago by kilvadyb
Modified:
7 years, 1 month ago
Reviewers:
kisg, Paul Lind, palfia, danno, Yang
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Fixed crashes exposed though fuzzing. Port r17886 (e2fb3ed) Original commit message: The %_OneByteSeqStringSetChar intrinsic expects its arguments to be checked before being called for efficiency reasons, but the fuzzer provided no such checks. Now the intrinsic is robust to bad input if FLAG_debug_code is set. R=yangguo@chromium.org TEST=test/mjsunit/regress/regress-320948.js BUG=chromium:320948 LOG=Y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -45 lines) Patch
M src/mips/full-codegen-mips.cc View 3 chunks +18 lines, -25 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +89 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 1 month ago (2013-11-19 20:51:09 UTC) #1
Paul Lind
I do have some nits on this, but since this is a build-breaker for MIPS, ...
7 years, 1 month ago (2013-11-19 22:18:50 UTC) #2
Paul Lind
7 years, 1 month ago (2013-11-19 22:25:09 UTC) #3
Committed as r17891.

Powered by Google App Engine
This is Rietveld 408576698