Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 68793007: Added three histograms to track the following TCP connection latency (Closed)

Created:
7 years, 1 month ago by ramant (doing other things)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added three histograms to track the following TCP connection latency intervals. a) t <= 10ms b) 10ms < t <= 20ms c) 20ms < t (or no previous time) R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235652

Patch Set 1 #

Patch Set 2 : Added new histograms to histograms.xml #

Total comments: 4

Patch Set 3 : fixed jar's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -22 lines) Patch
M net/socket/transport_client_socket_pool.h View 2 chunks +8 lines, -3 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 1 3 chunks +38 lines, -19 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
Hi Jim, This is a first cut at tracking the connection latency intervals for <=10ms, ...
7 years, 1 month ago (2013-11-13 20:45:55 UTC) #1
jar (doing other things)
lgtm (please add histograms.xml changes)
7 years, 1 month ago (2013-11-15 02:48:41 UTC) #2
ramant (doing other things)
Added new histograms to histograms.xml. PTAL. thanks.
7 years, 1 month ago (2013-11-15 03:53:21 UTC) #3
jar (doing other things)
LGTM % nits https://codereview.chromium.org/68793007/diff/50001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/68793007/diff/50001/tools/metrics/histograms/histograms.xml#newcode30202 tools/metrics/histograms/histograms.xml:30202: + <group name="LessThanOrEqual_10ms" label="less than or ...
7 years, 1 month ago (2013-11-15 05:38:15 UTC) #4
ramant (doing other things)
https://codereview.chromium.org/68793007/diff/50001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/68793007/diff/50001/tools/metrics/histograms/histograms.xml#newcode30202 tools/metrics/histograms/histograms.xml:30202: + <group name="LessThanOrEqual_10ms" label="less than or equlal to 10ms."/> ...
7 years, 1 month ago (2013-11-15 06:37:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/68793007/100001
7 years, 1 month ago (2013-11-15 06:47:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224979
7 years, 1 month ago (2013-11-15 10:05:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/68793007/100001
7 years, 1 month ago (2013-11-15 16:04:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/68793007/100001
7 years, 1 month ago (2013-11-15 22:11:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/68793007/100001
7 years, 1 month ago (2013-11-16 00:43:25 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 07:59:36 UTC) #11
Message was sent while issue was closed.
Change committed as 235652

Powered by Google App Engine
This is Rietveld 408576698