Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 687913003: app_list: Moved FolderImageSource into folder_image.cc. (Closed)

Created:
6 years, 1 month ago by Matt Giuca
Modified:
6 years, 1 month ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@ares-allapps-icon
Project:
chromium
Visibility:
Public.

Description

app_list: Moved FolderImageSource into folder_image.cc. It is now a private implementation detail of the folder_image module. FolderImage now exposes GetTopIconsBounds to AppsContainerView. BUG=425444 Committed: https://crrev.com/baeb7335a7f83fc289a6c55829809ed75b573a58 Cr-Commit-Position: refs/heads/master@{#302731}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Formatting (the ClangFormat rules have changed). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -188 lines) Patch
M ui/app_list/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/folder_image.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ui/app_list/folder_image.cc View 1 2 3 2 chunks +129 lines, -4 lines 0 comments Download
D ui/app_list/folder_image_source.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/app_list/folder_image_source.cc View 1 1 chunk +0 lines, -122 lines 0 comments Download
M ui/app_list/views/apps_container_view.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Matt Giuca
6 years, 1 month ago (2014-11-03 05:49:03 UTC) #2
calamity
lgtm. RIP folder_image_source.
6 years, 1 month ago (2014-11-04 06:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687913003/80001
6 years, 1 month ago (2014-11-05 00:36:32 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:80001)
6 years, 1 month ago (2014-11-05 01:27:32 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 01:27:58 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/baeb7335a7f83fc289a6c55829809ed75b573a58
Cr-Commit-Position: refs/heads/master@{#302731}

Powered by Google App Engine
This is Rietveld 408576698