Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 687903004: Remove component apps that should not used in the force-app mode. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
mtomasz, benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove component apps that should not used in the kiosk-mode. BUG=427114 TEST=None Committed: https://crrev.com/c890ad3377e334a1264a31c0c5f9d4083f008f20 Cr-Commit-Position: refs/heads/master@{#302214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/extensions/component_loader.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
hirono
PTAL the CL? Thank you!
6 years, 1 month ago (2014-10-29 12:32:58 UTC) #2
mtomasz
lgtm
6 years, 1 month ago (2014-10-29 12:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687903004/1
6 years, 1 month ago (2014-10-29 12:57:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20882)
6 years, 1 month ago (2014-10-29 13:03:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687903004/1
6 years, 1 month ago (2014-10-30 03:24:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21145)
6 years, 1 month ago (2014-10-30 03:27:55 UTC) #11
hirono
@benwells - PTAL the CL? Thanks!
6 years, 1 month ago (2014-10-30 03:51:52 UTC) #13
benwells
On 2014/10/30 03:51:52, hirono wrote: > @benwells - PTAL the CL? Thanks! lgtm
6 years, 1 month ago (2014-10-30 21:35:09 UTC) #14
hirono
On 2014/10/30 21:35:09, benwells wrote: > On 2014/10/30 03:51:52, hirono wrote: > > @benwells - ...
6 years, 1 month ago (2014-10-31 02:24:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687903004/1
6 years, 1 month ago (2014-10-31 02:25:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 02:44:47 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 02:45:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c890ad3377e334a1264a31c0c5f9d4083f008f20
Cr-Commit-Position: refs/heads/master@{#302214}

Powered by Google App Engine
This is Rietveld 408576698