Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 687903003: Cleanup: Remove unneeded ui_test_utils.h includes. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, asanka, felt, nkostylev+watch_chromium.org, zea+watch_chromium.org, posciak+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, Dmitry Titov, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, sadrul, markusheintz_, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, pvalenzuela+watch_chromium.org, rlp+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, jennb, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, jianli, oshima+watch_chromium.org, Michael van Ouwerkerk, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, kalyank, plundblad+watch_chromium.org, tfarina, mcasas+watch_chromium.org, benjhayden+dwatch_chromium.org, dtseng+watch_chromium.org, wjia+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded ui_test_utils.h includes. Committed: https://crrev.com/af7f4157b465639dbfb9d1b2ed78fabb9ed4566e Cr-Commit-Position: refs/heads/master@{#302347}

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : fix cros #

Patch Set 4 : fix cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -73 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/apps/app_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_tester.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/sync_setup_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_network/system_network_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/background_app_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_fullscreen_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_functional_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/gtalk_extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/hotword_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/access_token_store_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/predictor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/global_error/global_error_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
The lack of "ui_test_utils::" is an obvious sign that they shouldn't have this #include. In ...
6 years, 1 month ago (2014-10-31 21:35:54 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-10-31 21:55:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687903003/60001
6 years, 1 month ago (2014-10-31 22:01:04 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-31 23:19:28 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/af7f4157b465639dbfb9d1b2ed78fabb9ed4566e Cr-Commit-Position: refs/heads/master@{#302347}
6 years, 1 month ago (2014-10-31 23:20:07 UTC) #7
tfarina
6 years, 1 month ago (2014-11-04 13:32:03 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698